This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 48
fix(publish): mark scripts as executable #157
Merged
legobeat
merged 1 commit into
MetaMask:main
from
legobeat:chore-make-scripts-executable
Sep 13, 2023
Merged
fix(publish): mark scripts as executable #157
legobeat
merged 1 commit into
MetaMask:main
from
legobeat:chore-make-scripts-executable
Sep 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Gudahtt
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
legobeat
added a commit
to legobeat/eth-simple-keyring
that referenced
this pull request
Sep 14, 2023
legobeat
added a commit
to legobeat/eth-simple-keyring
that referenced
this pull request
Sep 14, 2023
* 5.1.0 * fix incorrect changelog entry for 5.0.0 --------- This was originally merged as d0d5c97 but rebased on top of MetaMask#157 to retrigger the publish. --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: legobt <[email protected]>
legobeat
added a commit
to legobeat/eth-simple-keyring
that referenced
this pull request
Sep 14, 2023
* 5.1.0 * fix incorrect changelog entry for 5.0.0 --------- This was originally merged as d0d5c97 but rebased on top of MetaMask#157 to retrigger the publish. --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: legobt <[email protected]>
legobeat
added a commit
to legobeat/eth-simple-keyring
that referenced
this pull request
Sep 14, 2023
* 5.1.0 * fix incorrect changelog entry for 5.0.0 --------- This was originally merged as d0d5c97 but rebased on top of MetaMask#157 to retrigger the publish. --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: legobt <[email protected]>
legobeat
added a commit
to legobeat/eth-simple-keyring
that referenced
this pull request
Sep 14, 2023
This reverts commit d0d5c97 which released v5.1.0. This is only done in order to get a proper publish from the main branch after merge of MetaMask#157, which fixes a CI error. 5.1.0 will be rereleased and published as-is.
Merged
legobeat
added a commit
to legobeat/eth-simple-keyring
that referenced
this pull request
Sep 14, 2023
This reverts commit d0d5c97 which released v5.1.0. This is only done in order to get a proper publish from the main branch after merge of MetaMask#157, which fixes a CI error. 5.1.0 will be rereleased and published as-is.
Closed
legobeat
added a commit
that referenced
this pull request
Sep 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the failing publish attempt of
v5.1.0
by marking the shell scripts underscripts/
as executable.Related