chore: restructuring design system react component code into folders #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,9 @@ module.exports = merge(baseConfig, { | |||
| // The display name when running multiple projects | |||
| displayName, | |||
|
|
|||
| // Add coverage ignore patterns | |||
| coveragePathIgnorePatterns: ['/node_modules/', 'index.ts'], | |||
There was a problem hiding this comment.
Ignoring index files from testing coverage
georgewrmarshall
force-pushed
the
part/react-text-1
branch
from
f2ea1a5
to
f0ecfeb
Compare
| @@ -14,6 +14,9 @@ module.exports = merge(baseConfig, { | |||
| // The display name when running multiple projects | |||
| displayName, | |||
|
|
|||
| // Add coverage ignore patterns | |||
| coveragePathIgnorePatterns: ['index.ts'], | |||
There was a problem hiding this comment.
Ignoring index files from test coverage as they only re-export components. We could add tests for these in the future, but will ignore them for now.
| @@ -0,0 +1,2 @@ | |||
| export { Button } from './Button'; | |||
| export type { ButtonProps } from './Button'; | |||
There was a problem hiding this comment.
Adding index file for Button
| export type { TextProps } from './text'; | ||
|
|
||
| export { Button } from './button'; | ||
| export type { ButtonProps } from './button'; |
There was a problem hiding this comment.
Adding root index file in components folder
| @@ -0,0 +1,2 @@ | |||
| export { Text, TextVariant } from './Text'; | |||
There was a problem hiding this comment.
Exporting Text and Text types
There was a problem hiding this comment.
Removing unnecessary index test file as we are now ignoring index files from testing coverage
brianacnguyen
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR restructures the existing example components within the
design-system-reactpackage by moving them into individual component folders. This organization update aims to prepare for the addition ofTextand other new components, promoting better organization and modularity within the component library. This change facilitates easier navigation and scalability as new components are added.Related Issues
Fixes: N/A
Manual Testing Steps
yarn storybookyarn buildensure that components are still builtScreenshots/Recordings
Before
before720.mov
After
after720.mov
Pre-merge Author Checklist
Pre-merge Reviewer Checklist