-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test adding Infura to the MetaMask docs #1325
Conversation
Signed-off-by: bgravenorst <[email protected]>
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
Preview published: test-integrate-infura |
Preview published: test-integrate-infura |
Signed-off-by: bgravenorst <[email protected]>
Signed-off-by: bgravenorst <[email protected]>
Preview published: test-integrate-infura |
4761d95
to
cfbd78f
Compare
|
||
:::info | ||
|
||
Failover support is available on Mainnet only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently incorrect and misleading so should be updated before merging. We should list the correct networks that support failover. Additionally, perhaps move the "Partners and privacy policies" content to the "services/reference/[NETWORK]/index.md file for the appropriate networks.
Note: Networks that support failover have different partners so it cannot be generic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as per @bgravenorst approval in Slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests pass
Test adding Infura to the MetaMask docs