Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test adding Infura to the MetaMask docs #1325

Merged
merged 47 commits into from
Jun 27, 2024
Merged

Conversation

bgravenorst
Copy link
Contributor

Test adding Infura to the MetaMask docs

Signed-off-by: bgravenorst <[email protected]>
Copy link

socket-security bot commented May 31, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

Copy link

Preview published: test-integrate-infura

Copy link

github-actions bot commented Jun 1, 2024

Preview published: test-integrate-infura

Copy link

Preview published: test-integrate-infura


:::info

Failover support is available on Mainnet only.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently incorrect and misleading so should be updated before merging. We should list the correct networks that support failover. Additionally, perhaps move the "Partners and privacy policies" content to the "services/reference/[NETWORK]/index.md file for the appropriate networks.

Note: Networks that support failover have different partners so it cannot be generic.

services/reference/ipfs/index.md Outdated Show resolved Hide resolved
m4sterbunny
m4sterbunny previously approved these changes Jun 27, 2024
Copy link
Contributor

@m4sterbunny m4sterbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per @bgravenorst approval in Slack

Copy link
Contributor

@m4sterbunny m4sterbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all tests pass

@joaniefromtheblock joaniefromtheblock merged commit 20b69c6 into main Jun 27, 2024
6 checks passed
@joaniefromtheblock joaniefromtheblock deleted the test-integrate-infura branch June 27, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants