Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code samples #1388

Merged
merged 17 commits into from
Jul 16, 2024
Merged

Update code samples #1388

merged 17 commits into from
Jul 16, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented Jul 5, 2024 •
edited
Loading

Description

  • Apply best practice for code samples
  • Also check for broken links and typos

Issue(s) fixed

Fixes #1375

Preview

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner July 5, 2024 10:58
@vercel Vercel
Copy link

vercel bot commented Jul 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview ✅ 52 resolved Jul 16, 2024 1:47am

@joaniefromtheblock joaniefromtheblock marked this pull request as draft July 5, 2024 11:03
@joaniefromtheblock joaniefromtheblock marked this pull request as ready for review July 11, 2024 19:51
@joaniefromtheblock joaniefromtheblock requested review from a team as code owners July 11, 2024 19:51
@joaniefromtheblock joaniefromtheblock marked this pull request as draft July 12, 2024 00:58
@socket-security Socket Security
Copy link

socket-security bot commented Jul 13, 2024 •
edited
Loading

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@joaniefromtheblock joaniefromtheblock marked this pull request as ready for review July 13, 2024 01:01
@alexandratran
Copy link
Contributor

Added comments in Vercel, will approve once those are addressed https://metamask-docs-qvpn4racj-metamask-web.vercel.app/

alexandratran
alexandratran approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joaniefromtheblock joaniefromtheblock merged commit c259dec into main Jul 16, 2024
9 checks passed
@joaniefromtheblock joaniefromtheblock deleted the uniform-code-samples branch July 16, 2024 09:12
alexandratran added a commit that referenced this pull request Jul 16, 2024
@alexandratran
Revert "Update code samples (#1388)"
e51285f 
This reverts commit c259dec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandratran alexandratran alexandratran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit Infura code samples
2 participants
@joaniefromtheblock @alexandratran