Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update trace_callMany #1535

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Update trace_callMany #1535

merged 2 commits into from
Sep 18, 2024

Conversation

joaniefromtheblock
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock commented Sep 9, 2024 •
edited
Loading

Description

Issue(s) fixed

Fixes #1534

Preview

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@joaniefromtheblock joaniefromtheblock requested a review from a team as a code owner September 9, 2024 07:38
@vercel Vercel
Copy link

vercel bot commented Sep 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 3:49pm

@joaniefromtheblock joaniefromtheblock changed the title Update `trace_callMany" Update trace_callMany Sep 9, 2024
alexandratran
alexandratran previously approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see the Infura PR for other note on trace_callMany param description.

@joaniefromtheblock joaniefromtheblock merged commit 282ec01 into main Sep 18, 2024
9 checks passed
@joaniefromtheblock joaniefromtheblock deleted the update-trace branch September 18, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandratran alexandratran alexandratran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infura Sync: Update trace_callMany
2 participants
@joaniefromtheblock @alexandratran