Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove POW methods. #1719

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Remove POW methods. #1719

merged 2 commits into from
Nov 15, 2024

Conversation

bgravenorst
Copy link
Contributor

Description

Removed the POW-related Linea methods. In some cases like eth_getWork, eth_submitWork, or eth_protocolVersion the methods display a the method [methodName] does not exist/is not available error

However some like the eth_getUncle* methods or eth_hashRate method will run but not return any logical result.

See: https://github.com/Consensys/butterfly/pull/17/files

Preview

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

Signed-off-by: bgravenorst <[email protected]>
@bgravenorst bgravenorst requested a review from a team as a code owner November 7, 2024 06:48
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 0:44am

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove eth_accounts?

@bgravenorst
Copy link
Contributor Author

Should we also remove eth_accounts?

I think we need some clarification on some of these methods (perhaps as part of a future PR). eth_accounts is not a PoW-only function so we need to figure out how we document this in the future.

Signed-off-by: bgravenorst <[email protected]>
@bgravenorst bgravenorst merged commit d21f02b into main Nov 15, 2024
17 of 18 checks passed
@bgravenorst bgravenorst deleted the DOC-499 branch November 15, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants