Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipfs cid v1 base32 #7693

Closed
wants to merge 4 commits into from
Closed

Ipfs cid v1 base32 #7693

wants to merge 4 commits into from

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Dec 11, 2019

Enables the use of CidV1 Base32 gateways for ENS-IPFS resolution. Uses ipfs.dweb.link by default, which has the same provider as ipfs.gateway.io, but is better for browser security. Rebased version of #7362, see that PR for more details.

Resolves #7362, Fixes #5724

pldespaigne and others added 3 commits December 11, 2019 14:24
add ipfs gateway to advanced settings
use ipfs gateway from settings
@metamaskbot
Copy link
Collaborator

Builds ready [3d658f4]

@metamaskbot
Copy link
Collaborator

Builds ready [44885c7]

@rekmarks rekmarks marked this pull request as ready for review December 12, 2019 16:44
@rekmarks
Copy link
Member Author

This wasn't necessary, I could push to the original PR.

@rekmarks rekmarks closed this Dec 12, 2019
@whymarrh whymarrh deleted the ipfs-cid-v1-rekmarks branch December 12, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security concern - IPFS ENS Resolving
3 participants