temp+fix: Add migration to fix NotificationServicesController bug (#1…

…2219)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

The purpose of this PR is to fix an error apparently caused by a missing
`NotificationServicesController` property on the
`state.engine.backgroundState`

## **Related issues**

Fixes: #12207 

## **Manual testing steps**

Although we didn't pinpoint what was causing the
`NotificationServicesController` to be missing, this code fills in the
data if it is missing.

## **Screenshots/Recordings**

n/a

### **Before**

n/a

### **After**

n/a

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: sethkfman <[email protected]>

.android.env.example

@@ -9,7 +9,7 @@ export FCM_CONFIG_PROJECT_ID=
 export FCM_CONFIG_STORAGE_BUCKET=
 export FCM_CONFIG_MESSAGING_SENDER_ID=
 export FCM_CONFIG_APP_ID=
-export GOOGLE_SERVICES_B64_ANDROID=
+export GOOGLE_SERVICES_B64=
 #Notifications Feature Announcements
 export FEATURES_ANNOUNCEMENTS_ACCESS_TOKEN=
 export FEATURES_ANNOUNCEMENTS_SPACE_ID=

.depcheckrc.yml

@@ -49,17 +49,22 @@ ignores:
   - 'rn-nodeify'
 
   ## Unused devDependencies to investigate
+  - '@ethersproject/abi'
   - '@metamask/swappable-obj-proxy'
+  - '@react-native-picker/picker'
+  - '@rnhooks/keyboard'
   - '@segment/sovran-react-native'
   - '@tradle/react-native-http'
   - 'asyncstorage-down'
   - 'buffer'
   - 'd3-shape'
+  - 'dnode'
   - 'eciesjs'
   - 'eth-block-tracker'
   - 'eth-json-rpc-infura'
   - 'events'
   - 'https-browserify'
+  - 'obs-store'
   - 'path'
   - 'pbkdf2'
   - 'pify'
@@ -68,9 +73,11 @@ ignores:
   - 'react-native-aes-crypto'
   - 'react-native-aes-crypto-forked'
   - 'react-native-crypto'
+  - 'react-native-flash-message'
   - 'react-native-level-fs'
   - 'react-native-os'
   - 'react-native-randombytes'
+  - 'react-native-redash'
   - 'react-native-swipe-gestures'
   - 'react-native-tcp'
   - 'socket.io-client'

.detoxrc.js

@@ -1,23 +1,18 @@
 /** @type {Detox.DetoxConfig} */
 module.exports = {
   artifacts: {
-    rootDir: "./artifacts",
+    rootDir: "./artifacts/screenshots",
     plugins: {
       screenshot: {
         shouldTakeAutomaticSnapshots: true,
         keepOnlyFailedTestsArtifacts: true,
         takeWhen: {
           testStart: false,
           testDone: false,
-        },
-      },
-      video: {
-        enabled: true,  // Enable video recording
-        keepOnlyFailedTestsArtifacts: true,  // Keep only failed tests' videos
+        }
       },
     },
   },
-
   testRunner: {
     args: {
       $0: 'jest',

.eslintrc.js

@@ -51,12 +51,6 @@ module.exports = {
       rules: {
         // under discussion
         'no-unused-vars': 'off',
-        'react/no-unstable-nested-components': [
-          'warn',
-          {
-            allowAsProps: true,
-          },
-        ],
       },
     },
     {

.github/CODEOWNERS

@@ -10,9 +10,6 @@ app/component-library/               @MetaMask/design-system-engineers
 patches/                             @MetaMask/mobile-platform
 app/core/Engine.ts                   @MetaMask/mobile-platform
 app/core/Engine.test.js              @MetaMask/mobile-platform
-app/core/Analytics/                  @MetaMask/mobile-platform
-app/util/metrics/                    @MetaMask/mobile-platform
-app/components/hooks/useMetrics/     @MetaMask/mobile-platform
 
 # Supply Chain Team
 bitrise.yml                          @MetaMask/supply-chain @MetaMask/mobile-platform

.github/workflows/add-team-label.yml

@@ -7,6 +7,8 @@ on:
 
 jobs:
   add-team-label:
-    uses: metamask/github-tools/.github/workflows/add-team-label.yml@18af6e4b56a18230d1792480e249ebc50b324927
+    uses: metamask/github-tools/.github/workflows/add-team-label.yml@058012b49ff2fbd9649c566ba43b29497f93b21d
+    permissions:
+      pull-requests: write
     secrets:
-      TEAM_LABEL_TOKEN: ${{ secrets.TEAM_LABEL_TOKEN }}
+      PERSONAL_ACCESS_TOKEN: ${{ secrets.RELEASE_LABEL_TOKEN }}

.github/workflows/bump-version-name.yml

@@ -0,0 +1,30 @@
+name: Bump version name
+on:
+  pull_request:
+    branches:
+      - develop
+      - main
+    types: [opened]
+  merge_group:
+    types: [checks_requested]
+
+jobs:
+  bump-version-name:
+    runs-on: ubuntu-latest
+    if: "contains(github.head_ref, 'release/')"
+    permissions:
+      contents: write  
+    steps:
+    - uses: actions/checkout@v3
+    - name: Bump script
+      env:
+        HEAD_REF: ${{ github.head_ref }}
+      run: |
+        ./scripts/bump-version.sh "$HEAD_REF"
+        git diff
+        git config user.name metamaskbot
+        git config user.email [email protected]
+        git add bitrise.yml
+        git add package.json
+        git commit -m "Bump version name"
+        git push origin HEAD:"$HEAD_REF" --force

.github/workflows/create-release-pr.yml

@@ -9,18 +9,15 @@ on:
       semver-version:
         description: 'A semantic version. eg: x.x.x'
         required: true
+      version-number:
+        description: 'A natural version number. eg: 862'
+        required: true
       previous-version-tag:
         description: 'Previous release version tag. eg: v7.7.0'
         required: true
 jobs:
-  generate-build-version:
-    uses: MetaMask/metamask-mobile-build-version/.github/workflows/[email protected]
-    permissions:
-      id-token: write
-
   create-release-pr:
     runs-on: ubuntu-latest
-    needs: generate-build-version
     permissions:
       contents: write
       pull-requests: write
@@ -39,19 +36,21 @@ jobs:
           # The workaround is to use a personal access token (BUG_REPORT_TOKEN) instead of
           # the default GITHUB_TOKEN for the checkout action.
           token: ${{ secrets.BUG_REPORT_TOKEN }}
-
       - name: Set up Node.js
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
           cache: yarn
       - name: Install dependencies
         run: yarn --immutable
-      - name: Create Release & Changelog PR
-        id: create-release-changelog-pr
+      - name: Set Versions
+        id: set-versions
+        shell: bash
+        run: SEMVER_VERSION=${{ github.event.inputs.semver-version }} VERSION_NUMBER=${{ github.event.inputs.version-number }} yarn set-version
+      - name: Create Release PR
+        id: create-release-pr
         shell: bash
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          BASE_BRANCH: ${{ github.event.inputs.base-branch }}
         run: |
-          ./scripts/create-release-pr.sh ${{ github.event.inputs.previous-version-tag }} ${{ github.event.inputs.semver-version }} ${{ needs.generate-build-version.outputs.build-version }}
+          ./scripts/create-release-pr.sh ${{ github.event.inputs.previous-version-tag }} ${{ github.event.inputs.semver-version }}

.gitignore

@@ -40,7 +40,6 @@ android/app/_build*
 
 # if we ever want to add google services
 android/app/google-services.json
-ios/GoogleService-Info.plist
 
 # node.js
 node_modules/
@@ -125,9 +124,3 @@ app/util/termsOfUse/termsOfUseContent.ts
 docs/assets/termsOfUse.html
 
 /app/images/branding
-
-# build metadata
-android/app/src/main/assets/modules.json
-
-# Google firebase base64 derived configs
-**/GoogleService-Info.plist

.ios.env.example

@@ -8,7 +8,7 @@ FCM_CONFIG_PROJECT_ID=
 FCM_CONFIG_STORAGE_BUCKET=
 FCM_CONFIG_MESSAGING_SENDER_ID=
 FCM_CONFIG_APP_ID=
-GOOGLE_SERVICES_B64_IOS=
+GOOGLE_SERVICES_B64=
 #Notifications Feature Announcements
 FEATURES_ANNOUNCEMENTS_ACCESS_TOKEN=
 FEATURES_ANNOUNCEMENTS_SPACE_ID=

.iyarc

@@ -0,0 +1,3 @@
+# ReDoS vulnerability, no impact to this application, and fix not backported yet to the versions we use
+
+GHSA-c2qf-rxjj-qqgw

.js.env.example

@@ -68,19 +68,18 @@ export SEGMENT_FLUSH_INTERVAL="1"
 export SEGMENT_FLUSH_EVENT_LIMIT="1"
 
 # URL of security alerts API used to validate dApp requests.
-export SECURITY_ALERTS_API_URL="https://security-alerts.api.cx.metamask.io"
+export SECURITY_ALERTS_API_URL="http://localhost:3000"
 
 # Temporary mechanism to enable security alerts API prior to release.
-export MM_SECURITY_ALERTS_API_ENABLED="true"
+export SECURITY_ALERTS_API_ENABLED="true"
 # Firebase
 export FCM_CONFIG_API_KEY=""
 export FCM_CONFIG_AUTH_DOMAIN=""
 export FCM_CONFIG_PROJECT_ID=""
 export FCM_CONFIG_STORAGE_BUCKET=""
 export FCM_CONFIG_MESSAGING_SENDER_ID=""
 export FCM_CONFIG_APP_ID=""
-export GOOGLE_SERVICES_B64_ANDROID=""
-export GOOGLE_SERVICES_B64_IOS=""
+export GOOGLE_SERVICES_B64=""
 #Notifications Feature Announcements
 export FEATURES_ANNOUNCEMENTS_ACCESS_TOKEN=
 export FEATURES_ANNOUNCEMENTS_SPACE_ID=
@@ -91,10 +90,7 @@ export MM_ENABLE_SETTINGS_PAGE_DEV_OPTIONS="true"
 # The endpoint used to submit errors and tracing data to Sentry for dev environment.
 # export MM_SENTRY_DSN_DEV=
 
-# Per dapp selected network (Amon Hen) feature flag
-export MM_PER_DAPP_SELECTED_NETWORK=""
-
-export MM_CHAIN_PERMISSIONS=""
-
+# Multichain Feature flag
+export MULTICHAIN_V1=""
 #Multichain feature flag specific to UI changes
 export MM_MULTICHAIN_V1_ENABLED=""

.storybook/storybook.requires.js

@@ -126,7 +126,7 @@ const getStories = () => {
     "./app/components/Views/confirmations/components/UI/InfoRow/InfoRow.stories.tsx": require("../app/components/Views/confirmations/components/UI/InfoRow/InfoRow.stories.tsx"),
     "./app/components/Views/confirmations/components/UI/ExpandableSection/ExpandableSection.stories.tsx": require("../app/components/Views/confirmations/components/UI/ExpandableSection/ExpandableSection.stories.tsx"),
     "./app/components/Views/confirmations/components/UI/Tooltip/Tooltip.stories.tsx": require("../app/components/Views/confirmations/components/UI/Tooltip/Tooltip.stories.tsx"),
-    "./app/component-library/components/Texts/SensitiveText/SensitiveText.stories.tsx": require("../app/component-library/components/Texts/SensitiveText/SensitiveText.stories.tsx"),
+    "./app/components/Views/confirmations/components/UI/CopyButton/CopyButton.stories.tsx": require("../app/components/Views/confirmations/components/UI/CopyButton/CopyButton.stories.tsx"),
   };
 };
 

.vscode/settings.json

@@ -6,7 +6,5 @@
   "cucumberautocomplete.steps": ["wdio/step-definitions/**/*.js"],
   "cucumberautocomplete.syncfeatures": "wdio/to/features/*.feature",
   "cucumberautocomplete.strictGherkinCompletion": true,
-  "typescript.tsdk": "node_modules/typescript/lib",
-  "javascript.preferences.importModuleSpecifier": "relative",
-  "typescript.preferences.importModuleSpecifier": "relative"
+  "typescript.tsdk": "node_modules/typescript/lib"
 }