full url instead of hostname

MetaMask · Nov 13, 2024 · aaf4963 · aaf4963
1 parent e627d42
commit aaf4963
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/app/store/sagas/xmlHttpRequestOverride.test.ts b/app/store/sagas/xmlHttpRequestOverride.test.ts
@@ -71,7 +71,7 @@ describe('overrideXMLHttpRequest', () => {
     const xhr = new XMLHttpRequest();
     xhr.onload = () => {
       expect(mockTrace).toHaveBeenCalledWith({
-        name: 'api.example.com',
+        name: 'https://api.example.com/data',
         op: trace.TraceOperation.NoBasicFunctionalityHttp,
       });
       done();
@@ -97,7 +97,7 @@ describe('createLoggingXHROverride', () => {
     const xhr = new XMLHttpRequest();
     xhr.onload = () => {
       expect(mockTrace).toHaveBeenCalledWith({
-        name: 'api.example.com',
+        name: 'https://api.example.com/data',
         op: trace.TraceOperation.Http,
       });
       done();

diff --git a/app/store/sagas/xmlHttpRequestOverride.ts b/app/store/sagas/xmlHttpRequestOverride.ts
@@ -46,9 +46,8 @@ function createXHROverride(options: XHROverrideOptions) {
     password?: string | null,
   ) {
     currentUrl = url?.toString();
-    const hostname = new URL(currentUrl).hostname;
     trace({
-      name: hostname as TraceName,
+      name: currentUrl as TraceName,
       op: options.operation,
     });
     return originalOpen.apply(this, [
@@ -61,13 +60,12 @@ function createXHROverride(options: XHROverrideOptions) {
   };
 
   global.XMLHttpRequest.prototype.send = function (...args: unknown[]) {
-    const hostname = new URL(currentUrl).hostname;
     this.addEventListener('load', () => {
-      endTrace({ name: hostname as TraceName });
+      endTrace({ name: currentUrl as TraceName });
     });
 
     this.addEventListener('error', () => {
-      endTrace({ name: hostname as TraceName });
+      endTrace({ name: currentUrl as TraceName });
     });
 
     if (options.beforeSend && options.beforeSend(currentUrl)) {