Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple accounts support in ledger #10109

Merged
merged 99 commits into from
Jul 16, 2024

Commits on Apr 8, 2024

  1. feat: add library @metamask/eth-ledger-bridge-keyring, and the patch …

    …the library with local change.
    
    1. modify the Engine.ts to use new library
    2. modify Ledger.ts to use new library
    
    will expect some errors during build, will fix this error and unit tests in next commit.
    dawnseeker8 committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    1ff5849 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Configuration menu
    Copy the full SHA
    15434b2 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    c997d0c View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Merge branch 'main' into feat/ledger-multiple-accounts-support

    # Conflicts:
    #	ios/MetaMask.xcodeproj/project.pbxproj
    dawnseeker8 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    a83521d View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge branch 'main' into feat/ledger-multiple-accounts-support

    # Conflicts:
    #	ios/MetaMask.xcodeproj/project.pbxproj
    dawnseeker8 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9be9588 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Configuration menu
    Copy the full SHA
    9e9e90b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9ddf32c View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge branch 'main' into feat/ledger-multiple-accounts-support

    # Conflicts:
    #	app/core/Engine.ts
    dawnseeker8 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    990e0b0 View commit details
    Browse the repository at this point in the history
  2. fix: Rebase from main

    dawnseeker8 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    d376691 View commit details
    Browse the repository at this point in the history
  3. feat: add package.tgz to project so that project can build without …

    …the need of release of library. also fix some issue of missing deviceId in library cause the bluetooth unable to connect.
    dawnseeker8 committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5eb781c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ee7efd4 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. feat: workable version with add multiple accounts and forget devices.…

    … Still need to refactory the code to remove unused functions.
    dawnseeker8 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    56f9229 View commit details
    Browse the repository at this point in the history
  2. feat: workable version with add multiple accounts and forget devices.…

    … Still need to refactory the code to remove unused functions.
    dawnseeker8 committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    f22b625 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Configuration menu
    Copy the full SHA
    fe9a06a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0cd5536 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Configuration menu
    Copy the full SHA
    bd47961 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    52b8967 View commit details
    Browse the repository at this point in the history
  3. feat: Try to fix the yarn setup integrity check failed because chec…

    …ksum not match.
    
    also improve the unit tests for ledger.ts to cover all functions.
    dawnseeker8 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d5be2ce View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Configuration menu
    Copy the full SHA
    aa4f2ed View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into feat/ledger-multiple-accounts-support

    # Conflicts:
    #	app/components/Nav/App/index.js
    #	app/core/Engine.ts
    #	ios/MetaMask.xcodeproj/project.pbxproj
    #	package.json
    #	yarn.lock
    dawnseeker8 committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    6f7721c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc848aa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    aa461e2 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    078cc28 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    ebfae11 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'main' into feat/ledger-multiple-accounts-support

    # Conflicts:
    #	app/core/Engine.ts
    #	app/core/Ledger/Ledger.test.ts
    #	app/core/Ledger/Ledger.ts
    #	patches/@MetaMask+keyring-controller+9.0.0.patch
    #	yarn.lock
    dawnseeker8 committed May 9, 2024
    Configuration menu
    Copy the full SHA
    5cf3c9d View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. feat: Rebase from main to upgrade to keyringController 13. Fix all bl…

    …ocken code.
    
    Enhance in BlockingActionModal with smooth animation to provide better user friendly interaction.
    
    add code to remove single accounts in actions.
    
    Still need to fix unit tests, however because MM mobile team will upgrade keyringController to 15, will start to fix unit tests after rerbase.
    dawnseeker8 committed May 10, 2024
    Configuration menu
    Copy the full SHA
    82e0a5d View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    a0c2b16 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Merge branch 'main' into feat/ledger-multiple-accounts-support-rebase

    # Conflicts:
    #	app/components/Views/ConnectHardware/SelectHardware/index.tsx
    #	app/components/Views/LedgerAccountInfo/index.tsx
    #	app/core/Ledger/Ledger.test.ts
    #	app/core/Ledger/Ledger.ts
    #	package.json
    #	patches/@MetaMask+keyring-controller+13.0.0.patch
    #	yarn.lock
    dawnseeker8 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    e9528dc View commit details
    Browse the repository at this point in the history
  2. fix: Rebase from main to upgrade to keyring-controller 16.

    This version will be first version which ledger work after keyring controller 16 upgrade.
    dawnseeker8 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    f9941c0 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Configuration menu
    Copy the full SHA
    192fdb4 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Configuration menu
    Copy the full SHA
    dcbda06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5dd2f51 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Configuration menu
    Copy the full SHA
    35cf1ec View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into feat/ledger-multiple-accounts-support-rebase

    # Conflicts:
    #	app/components/Nav/App/index.js
    #	app/components/Views/LedgerConnect/index.tsx
    #	app/core/Ledger/Ledger.ts
    dawnseeker8 committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    7a82dee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    07cc7c2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0158f84 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Configuration menu
    Copy the full SHA
    50fd23d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3a6566 View commit details
    Browse the repository at this point in the history
  3. feat: Fix ide complain about the navigationProp not contains pop method.

    Also fix the unit tests broken in Ledger.test.ts
    dawnseeker8 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c5b5c7d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7d9d345 View commit details
    Browse the repository at this point in the history
  5. feat: Remove the redundant file LedgerAccountInfo/index.tsx,

    Refine the test description.
    dawnseeker8 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d62e322 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f17359e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5ca0447 View commit details
    Browse the repository at this point in the history
  8. feat: update yarn.lock

    dawnseeker8 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    8d129da View commit details
    Browse the repository at this point in the history
  9. feat: update yarn.lock

    dawnseeker8 committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    646cec4 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    449fab3 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Configuration menu
    Copy the full SHA
    1999fe8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    354db11 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c0a85a9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    53e3b5f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ca5293d View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Configuration menu
    Copy the full SHA
    a710a74 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Configuration menu
    Copy the full SHA
    443b452 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Configuration menu
    Copy the full SHA
    915edbe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aced129 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    98b0175 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    073260c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0ebdd4f View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Configuration menu
    Copy the full SHA
    feca7e0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    59687e4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ef50cb9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    152f8b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Configuration menu
    Copy the full SHA
    4b12a26 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    e3e46f9 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Apply suggestions from code review

    commit Gustavo Antunes's code suggestion.
    
    Co-authored-by: Gustavo Antunes <[email protected]>
    dawnseeker8 and gantunesr authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    bdb32b0 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into feat/ledger-multiple-accounts-support-rebase

    # Conflicts:
    #	app/components/Views/AccountActions/AccountActions.constants.ts
    #	app/components/Views/AccountActions/AccountActions.test.tsx
    #	app/components/Views/AccountActions/AccountActions.tsx
    #	package.json
    #	yarn.lock
    dawnseeker8 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    11109b9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2c6bcee View commit details
    Browse the repository at this point in the history
  4. feat: fix lint error.

    dawnseeker8 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    17c21ad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9982b72 View commit details
    Browse the repository at this point in the history
  6. feat: Remove the patch to Keyring-controller 16 and move unlockLedger…

    …WalletAccount to Ledger.ts
    dawnseeker8 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4c545e1 View commit details
    Browse the repository at this point in the history
  7. feat: improve code coverage to Ledger.ts to 100%, remove the whitespa…

    …ce difference in patch file.
    dawnseeker8 committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2276ce7 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    ac0d26d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf96365 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Apply suggestions from code review

    Co-authored-by: Gustavo Antunes <[email protected]>
    dawnseeker8 and gantunesr authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8163e84 View commit details
    Browse the repository at this point in the history
  2. feat: commit some change after code review,, Following change has ber…

    …en done.
    
    1. create a constants.ts under core/ledger directory to contain the LEDGER_HD_PATH
    2. add `common.please_wait` message key in en.json, and remove the not common message key for ledger and qr code.
    dawnseeker8 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    938c08b View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'origin/feat/ledger-multiple-accounts-su…

    …pport-rebase' into feat/ledger-multiple-accounts-support-rebase
    dawnseeker8 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0d1d9cc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    076b661 View commit details
    Browse the repository at this point in the history
  5. feat: Refactor the getLedgerAccountsByPageto `getLedgerAccountsByOp…

    …eration`. and put opeartionType enuim to constants.ts
    dawnseeker8 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    eb3319e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    474b1e7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    06e6f6a View commit details
    Browse the repository at this point in the history
  8. feat: Create HardwareDeviceTypes enum to MetaMetrics.types.ts, and re…

    …factor all hardware relative metricEvent to use that new enum to keep all deviceTypes consistency.
    dawnseeker8 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    f05e7dd View commit details
    Browse the repository at this point in the history
  9. feat: refactor triggerRemoveHWAccount method to smaller pieces, int…

    …roduce `removeHardwareAccount`, `reselectFirstAccount` and `forgetDeviceIfRequired`
    dawnseeker8 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    662fb09 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. feat: remove console log.

    dawnseeker8 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    eb5c91f View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Co-authored-by: Gustavo Antunes <[email protected]>
    dawnseeker8 and gantunesr authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    65871e4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7c77ce1 View commit details
    Browse the repository at this point in the history
  4. feat: Remove cancel button onPress event and also remove correspondin…

    …g unit test for cancel button click.
    dawnseeker8 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    2251d21 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    611d5a4 View commit details
    Browse the repository at this point in the history
  6. feat: Change to use selectSelectedInternalAccount to get the select…

    …edAccount which contain selectedAddress, and metadata
    dawnseeker8 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    efefb63 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c182fc1 View commit details
    Browse the repository at this point in the history
  8. feat: fix the lint issue

    dawnseeker8 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c403ad3 View commit details
    Browse the repository at this point in the history
  9. Merge branch 'main' into feat/ledger-multiple-accounts-support-rebase

    # Conflicts:
    #	yarn.lock
    dawnseeker8 committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    e3d26a6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    368de0f View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Configuration menu
    Copy the full SHA
    1571f72 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c355be4 View commit details
    Browse the repository at this point in the history
  3. feat: to make account selection screen bigger so that more items can …

    …be shown in the screen.
    dawnseeker8 committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    fe4d92e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4ed3572 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. feat: Modify the AccountSelector component to make onCheck optional…

    …, and then modify `LedgerSelectAccount` component and `ConnectQRHardware` component to reflect the property changed.
    dawnseeker8 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c1a24b2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    90d86ab View commit details
    Browse the repository at this point in the history
  3. feat: Change the structure of LedgerSelectAccount and `LedgerConnec…

    …t` component to include a close icon, which will minic how the `ConnectQRHardware` component structure. hide the navigation header for `ledger Connect` screen.
    dawnseeker8 committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    df0bd74 View commit details
    Browse the repository at this point in the history