-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multiple accounts support in ledger #10109
feat: multiple accounts support in ledger #10109
Commits on Apr 8, 2024
-
feat: add library @metamask/eth-ledger-bridge-keyring, and the patch …
…the library with local change. 1. modify the Engine.ts to use new library 2. modify Ledger.ts to use new library will expect some errors during build, will fix this error and unit tests in next commit.
Configuration menu - View commit details
-
Copy full SHA for 1ff5849 - Browse repository at this point
Copy the full SHA 1ff5849View commit details
Commits on Apr 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 15434b2 - Browse repository at this point
Copy the full SHA 15434b2View commit details
Commits on Apr 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c997d0c - Browse repository at this point
Copy the full SHA c997d0cView commit details
Commits on Apr 12, 2024
-
Merge branch 'main' into feat/ledger-multiple-accounts-support
# Conflicts: # ios/MetaMask.xcodeproj/project.pbxproj
Configuration menu - View commit details
-
Copy full SHA for a83521d - Browse repository at this point
Copy the full SHA a83521dView commit details
Commits on Apr 17, 2024
-
Merge branch 'main' into feat/ledger-multiple-accounts-support
# Conflicts: # ios/MetaMask.xcodeproj/project.pbxproj
Configuration menu - View commit details
-
Copy full SHA for 9be9588 - Browse repository at this point
Copy the full SHA 9be9588View commit details
Commits on Apr 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9e9e90b - Browse repository at this point
Copy the full SHA 9e9e90bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ddf32c - Browse repository at this point
Copy the full SHA 9ddf32cView commit details
Commits on Apr 22, 2024
-
Merge branch 'main' into feat/ledger-multiple-accounts-support
# Conflicts: # app/core/Engine.ts
Configuration menu - View commit details
-
Copy full SHA for 990e0b0 - Browse repository at this point
Copy the full SHA 990e0b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d376691 - Browse repository at this point
Copy the full SHA d376691View commit details -
feat: add
package.tgz
to project so that project can build without ……the need of release of library. also fix some issue of missing deviceId in library cause the bluetooth unable to connect.
Configuration menu - View commit details
-
Copy full SHA for 5eb781c - Browse repository at this point
Copy the full SHA 5eb781cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee7efd4 - Browse repository at this point
Copy the full SHA ee7efd4View commit details
Commits on Apr 23, 2024
-
feat: workable version with add multiple accounts and forget devices.…
… Still need to refactory the code to remove unused functions.
Configuration menu - View commit details
-
Copy full SHA for 56f9229 - Browse repository at this point
Copy the full SHA 56f9229View commit details -
feat: workable version with add multiple accounts and forget devices.…
… Still need to refactory the code to remove unused functions.
Configuration menu - View commit details
-
Copy full SHA for f22b625 - Browse repository at this point
Copy the full SHA f22b625View commit details
Commits on Apr 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fe9a06a - Browse repository at this point
Copy the full SHA fe9a06aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cd5536 - Browse repository at this point
Copy the full SHA 0cd5536View commit details
Commits on Apr 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bd47961 - Browse repository at this point
Copy the full SHA bd47961View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52b8967 - Browse repository at this point
Copy the full SHA 52b8967View commit details -
feat: Try to fix the
yarn setup
integrity check failed because chec……ksum not match. also improve the unit tests for ledger.ts to cover all functions.
Configuration menu - View commit details
-
Copy full SHA for d5be2ce - Browse repository at this point
Copy the full SHA d5be2ceView commit details
Commits on Apr 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for aa4f2ed - Browse repository at this point
Copy the full SHA aa4f2edView commit details -
Merge branch 'main' into feat/ledger-multiple-accounts-support
# Conflicts: # app/components/Nav/App/index.js # app/core/Engine.ts # ios/MetaMask.xcodeproj/project.pbxproj # package.json # yarn.lock
Configuration menu - View commit details
-
Copy full SHA for 6f7721c - Browse repository at this point
Copy the full SHA 6f7721cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc848aa - Browse repository at this point
Copy the full SHA dc848aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa461e2 - Browse repository at this point
Copy the full SHA aa461e2View commit details
Commits on Apr 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 078cc28 - Browse repository at this point
Copy the full SHA 078cc28View commit details
Commits on May 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ebfae11 - Browse repository at this point
Copy the full SHA ebfae11View commit details
Commits on May 9, 2024
-
Merge branch 'main' into feat/ledger-multiple-accounts-support
# Conflicts: # app/core/Engine.ts # app/core/Ledger/Ledger.test.ts # app/core/Ledger/Ledger.ts # patches/@MetaMask+keyring-controller+9.0.0.patch # yarn.lock
Configuration menu - View commit details
-
Copy full SHA for 5cf3c9d - Browse repository at this point
Copy the full SHA 5cf3c9dView commit details
Commits on May 10, 2024
-
feat: Rebase from main to upgrade to keyringController 13. Fix all bl…
…ocken code. Enhance in BlockingActionModal with smooth animation to provide better user friendly interaction. add code to remove single accounts in actions. Still need to fix unit tests, however because MM mobile team will upgrade keyringController to 15, will start to fix unit tests after rerbase.
Configuration menu - View commit details
-
Copy full SHA for 82e0a5d - Browse repository at this point
Copy the full SHA 82e0a5dView commit details
Commits on Jun 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a0c2b16 - Browse repository at this point
Copy the full SHA a0c2b16View commit details
Commits on Jun 7, 2024
-
Merge branch 'main' into feat/ledger-multiple-accounts-support-rebase
# Conflicts: # app/components/Views/ConnectHardware/SelectHardware/index.tsx # app/components/Views/LedgerAccountInfo/index.tsx # app/core/Ledger/Ledger.test.ts # app/core/Ledger/Ledger.ts # package.json # patches/@MetaMask+keyring-controller+13.0.0.patch # yarn.lock
Configuration menu - View commit details
-
Copy full SHA for e9528dc - Browse repository at this point
Copy the full SHA e9528dcView commit details -
fix: Rebase from main to upgrade to keyring-controller 16.
This version will be first version which ledger work after keyring controller 16 upgrade.
Configuration menu - View commit details
-
Copy full SHA for f9941c0 - Browse repository at this point
Copy the full SHA f9941c0View commit details
Commits on Jun 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 192fdb4 - Browse repository at this point
Copy the full SHA 192fdb4View commit details
Commits on Jun 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dcbda06 - Browse repository at this point
Copy the full SHA dcbda06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dd2f51 - Browse repository at this point
Copy the full SHA 5dd2f51View commit details
Commits on Jun 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 35cf1ec - Browse repository at this point
Copy the full SHA 35cf1ecView commit details -
Merge branch 'main' into feat/ledger-multiple-accounts-support-rebase
# Conflicts: # app/components/Nav/App/index.js # app/components/Views/LedgerConnect/index.tsx # app/core/Ledger/Ledger.ts
Configuration menu - View commit details
-
Copy full SHA for 7a82dee - Browse repository at this point
Copy the full SHA 7a82deeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07cc7c2 - Browse repository at this point
Copy the full SHA 07cc7c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0158f84 - Browse repository at this point
Copy the full SHA 0158f84View commit details
Commits on Jun 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 50fd23d - Browse repository at this point
Copy the full SHA 50fd23dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3a6566 - Browse repository at this point
Copy the full SHA a3a6566View commit details -
feat: Fix ide complain about the navigationProp not contains pop method.
Also fix the unit tests broken in Ledger.test.ts
Configuration menu - View commit details
-
Copy full SHA for c5b5c7d - Browse repository at this point
Copy the full SHA c5b5c7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d9d345 - Browse repository at this point
Copy the full SHA 7d9d345View commit details -
feat: Remove the redundant file
LedgerAccountInfo/index.tsx
,Refine the test description.
Configuration menu - View commit details
-
Copy full SHA for d62e322 - Browse repository at this point
Copy the full SHA d62e322View commit details -
Configuration menu - View commit details
-
Copy full SHA for f17359e - Browse repository at this point
Copy the full SHA f17359eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ca0447 - Browse repository at this point
Copy the full SHA 5ca0447View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d129da - Browse repository at this point
Copy the full SHA 8d129daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 646cec4 - Browse repository at this point
Copy the full SHA 646cec4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 449fab3 - Browse repository at this point
Copy the full SHA 449fab3View commit details
Commits on Jun 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1999fe8 - Browse repository at this point
Copy the full SHA 1999fe8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 354db11 - Browse repository at this point
Copy the full SHA 354db11View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0a85a9 - Browse repository at this point
Copy the full SHA c0a85a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53e3b5f - Browse repository at this point
Copy the full SHA 53e3b5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca5293d - Browse repository at this point
Copy the full SHA ca5293dView commit details
Commits on Jun 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a710a74 - Browse repository at this point
Copy the full SHA a710a74View commit details
Commits on Jun 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 443b452 - Browse repository at this point
Copy the full SHA 443b452View commit details
Commits on Jul 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 915edbe - Browse repository at this point
Copy the full SHA 915edbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for aced129 - Browse repository at this point
Copy the full SHA aced129View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98b0175 - Browse repository at this point
Copy the full SHA 98b0175View commit details -
Configuration menu - View commit details
-
Copy full SHA for 073260c - Browse repository at this point
Copy the full SHA 073260cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ebdd4f - Browse repository at this point
Copy the full SHA 0ebdd4fView commit details
Commits on Jul 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for feca7e0 - Browse repository at this point
Copy the full SHA feca7e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59687e4 - Browse repository at this point
Copy the full SHA 59687e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef50cb9 - Browse repository at this point
Copy the full SHA ef50cb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 152f8b9 - Browse repository at this point
Copy the full SHA 152f8b9View commit details
Commits on Jul 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4b12a26 - Browse repository at this point
Copy the full SHA 4b12a26View commit details
Commits on Jul 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e3e46f9 - Browse repository at this point
Copy the full SHA e3e46f9View commit details
Commits on Jul 8, 2024
-
Apply suggestions from code review
commit Gustavo Antunes's code suggestion. Co-authored-by: Gustavo Antunes <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for bdb32b0 - Browse repository at this point
Copy the full SHA bdb32b0View commit details -
Merge branch 'main' into feat/ledger-multiple-accounts-support-rebase
# Conflicts: # app/components/Views/AccountActions/AccountActions.constants.ts # app/components/Views/AccountActions/AccountActions.test.tsx # app/components/Views/AccountActions/AccountActions.tsx # package.json # yarn.lock
Configuration menu - View commit details
-
Copy full SHA for 11109b9 - Browse repository at this point
Copy the full SHA 11109b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c6bcee - Browse repository at this point
Copy the full SHA 2c6bceeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17c21ad - Browse repository at this point
Copy the full SHA 17c21adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9982b72 - Browse repository at this point
Copy the full SHA 9982b72View commit details -
feat: Remove the patch to Keyring-controller 16 and move unlockLedger…
…WalletAccount to Ledger.ts
Configuration menu - View commit details
-
Copy full SHA for 4c545e1 - Browse repository at this point
Copy the full SHA 4c545e1View commit details -
feat: improve code coverage to Ledger.ts to 100%, remove the whitespa…
…ce difference in patch file.
Configuration menu - View commit details
-
Copy full SHA for 2276ce7 - Browse repository at this point
Copy the full SHA 2276ce7View commit details
Commits on Jul 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ac0d26d - Browse repository at this point
Copy the full SHA ac0d26dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf96365 - Browse repository at this point
Copy the full SHA bf96365View commit details
Commits on Jul 10, 2024
-
Apply suggestions from code review
Co-authored-by: Gustavo Antunes <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8163e84 - Browse repository at this point
Copy the full SHA 8163e84View commit details -
feat: commit some change after code review,, Following change has ber…
…en done. 1. create a constants.ts under core/ledger directory to contain the LEDGER_HD_PATH 2. add `common.please_wait` message key in en.json, and remove the not common message key for ledger and qr code.
Configuration menu - View commit details
-
Copy full SHA for 938c08b - Browse repository at this point
Copy the full SHA 938c08bView commit details -
Merge remote-tracking branch 'origin/feat/ledger-multiple-accounts-su…
…pport-rebase' into feat/ledger-multiple-accounts-support-rebase
Configuration menu - View commit details
-
Copy full SHA for 0d1d9cc - Browse repository at this point
Copy the full SHA 0d1d9ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 076b661 - Browse repository at this point
Copy the full SHA 076b661View commit details -
feat: Refactor the
getLedgerAccountsByPage
to `getLedgerAccountsByOp……eration`. and put opeartionType enuim to constants.ts
Configuration menu - View commit details
-
Copy full SHA for eb3319e - Browse repository at this point
Copy the full SHA eb3319eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 474b1e7 - Browse repository at this point
Copy the full SHA 474b1e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06e6f6a - Browse repository at this point
Copy the full SHA 06e6f6aView commit details -
feat: Create HardwareDeviceTypes enum to MetaMetrics.types.ts, and re…
…factor all hardware relative metricEvent to use that new enum to keep all deviceTypes consistency.
Configuration menu - View commit details
-
Copy full SHA for f05e7dd - Browse repository at this point
Copy the full SHA f05e7ddView commit details -
feat: refactor
triggerRemoveHWAccount
method to smaller pieces, int……roduce `removeHardwareAccount`, `reselectFirstAccount` and `forgetDeviceIfRequired`
Configuration menu - View commit details
-
Copy full SHA for 662fb09 - Browse repository at this point
Copy the full SHA 662fb09View commit details
Commits on Jul 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eb5c91f - Browse repository at this point
Copy the full SHA eb5c91fView commit details -
Apply suggestions from code review
Co-authored-by: Gustavo Antunes <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 65871e4 - Browse repository at this point
Copy the full SHA 65871e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c77ce1 - Browse repository at this point
Copy the full SHA 7c77ce1View commit details -
feat: Remove cancel button onPress event and also remove correspondin…
…g unit test for cancel button click.
Configuration menu - View commit details
-
Copy full SHA for 2251d21 - Browse repository at this point
Copy the full SHA 2251d21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 611d5a4 - Browse repository at this point
Copy the full SHA 611d5a4View commit details -
feat: Change to use
selectSelectedInternalAccount
to get the select……edAccount which contain selectedAddress, and metadata
Configuration menu - View commit details
-
Copy full SHA for efefb63 - Browse repository at this point
Copy the full SHA efefb63View commit details -
Configuration menu - View commit details
-
Copy full SHA for c182fc1 - Browse repository at this point
Copy the full SHA c182fc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c403ad3 - Browse repository at this point
Copy the full SHA c403ad3View commit details -
Merge branch 'main' into feat/ledger-multiple-accounts-support-rebase
# Conflicts: # yarn.lock
Configuration menu - View commit details
-
Copy full SHA for e3d26a6 - Browse repository at this point
Copy the full SHA e3d26a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 368de0f - Browse repository at this point
Copy the full SHA 368de0fView commit details
Commits on Jul 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1571f72 - Browse repository at this point
Copy the full SHA 1571f72View commit details -
feat: upgrade the eth-ledger-keyring-bridge library, remove the patch…
… for that library
Configuration menu - View commit details
-
Copy full SHA for c355be4 - Browse repository at this point
Copy the full SHA c355be4View commit details -
feat: to make account selection screen bigger so that more items can …
…be shown in the screen.
Configuration menu - View commit details
-
Copy full SHA for fe4d92e - Browse repository at this point
Copy the full SHA fe4d92eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ed3572 - Browse repository at this point
Copy the full SHA 4ed3572View commit details
Commits on Jul 16, 2024
-
feat: Modify the AccountSelector component to make
onCheck
optional……, and then modify `LedgerSelectAccount` component and `ConnectQRHardware` component to reflect the property changed.
Configuration menu - View commit details
-
Copy full SHA for c1a24b2 - Browse repository at this point
Copy the full SHA c1a24b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90d86ab - Browse repository at this point
Copy the full SHA 90d86abView commit details -
feat: Change the structure of
LedgerSelectAccount
and `LedgerConnec……t` component to include a close icon, which will minic how the `ConnectQRHardware` component structure. hide the navigation header for `ledger Connect` screen.
Configuration menu - View commit details
-
Copy full SHA for df0bd74 - Browse repository at this point
Copy the full SHA df0bd74View commit details