Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ramp): improve amount editing formatting #11613

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Oct 3, 2024

Description

This PR improves the changes introduced in #9039, which formatted the amount input on-the-fly as the user typed it for better readability (123456.78 to 123,456.78). However the formatting was introducing an unexpected state when the user typed the decimal separator (See Before video).

This PR brings back the full formatting when the user has finishing editing the amount. While editing, the amount will be grouped in 3 chars separated by space to improve readability of the input.

Related issues

Fixes:

Manual testing steps

  1. Go to Buy flow
  2. Reach the Build Quote page
  3. Input a large amount to buy

Screenshots/Recordings

Before

When decimal separator is typed, the amount remains unchanged.
When deleting the decimal separator, the amount remains unchanged.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-03.at.14.10.18.mp4

After

The amount represents every state of the amount change, even partial ones lile 1234. or 1234.0

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-03.at.14.08.39.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions github-actions bot added the team-ramp issues related to Ramp features label Oct 3, 2024
@wachunei wachunei added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 3, 2024
@wachunei wachunei marked this pull request as ready for review October 8, 2024 15:02
@wachunei wachunei requested review from a team as code owners October 8, 2024 15:02
@wachunei wachunei added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: cde58c7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/56f67230-a56d-424c-91f1-b80f3d8f1d88

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Oct 8, 2024

@wachunei wachunei added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

1 participant