Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom names for snap accounts (Flask only) #12198

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: custom names for snap accounts (Flask only) #12198

wants to merge 16 commits into from
+686 −28

Commits on Nov 15, 2024

  1. scaffold approvals

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7bdfa73 View commit details
    Browse the repository at this point in the history

  2. confirmation modal is rendering

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f3c28b6 View commit details
    Browse the repository at this point in the history

  3. render custom account name approval

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6a6034a View commit details
    Browse the repository at this point in the history

  4. render snap suggested name

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    cd0c7e3 View commit details
    Browse the repository at this point in the history

  5. pass names back to snap keyring

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6a14595 View commit details
    Browse the repository at this point in the history

  6. set custom account names and check for duplicates

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    34c1a11 View commit details
    Browse the repository at this point in the history

  7. check if account name is taken in the front end

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f48a592 View commit details
    Browse the repository at this point in the history

  8. better error handling

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    be06510 View commit details
    Browse the repository at this point in the history

  9. wip scaffold success/error messages

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    64448f3 View commit details
    Browse the repository at this point in the history

  10. remove error handling

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    c9b5d61 View commit details
    Browse the repository at this point in the history

  11. improve snap keyring tests

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ec3a674 View commit details
    Browse the repository at this point in the history

  12. test SnapAccountCustomNameApproval

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    1fe2215 View commit details
    Browse the repository at this point in the history

  13. move functions out of useeffect

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5dc0e11 View commit details
    Browse the repository at this point in the history

  14. address Gutos feedback

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    09ac3ca View commit details
    Browse the repository at this point in the history

  15. simplify SnapAccountCustomName

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    05a4231 View commit details
    Browse the repository at this point in the history

  16. fix lint

    @owencraston
    owencraston committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    dd8c2fa View commit details
    Browse the repository at this point in the history