-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add migration to fix NotificationServicesController bug #12219
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12219 +/- ##
==========================================
+ Coverage 55.78% 56.22% +0.43%
==========================================
Files 1786 1787 +1
Lines 40362 40369 +7
Branches 5054 5061 +7
==========================================
+ Hits 22516 22696 +180
+ Misses 16297 16124 -173
Partials 1549 1549 ☔ View full report in Codecov by Sentry. |
Let's also add the verification to the getTags file
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bitrise❌❌❌ Commit hash: ecbcfa9 Note
Tip
|
Quality Gate passedIssues Measures |
Description
The purpose of this PR is to fix an error apparently caused by a missing
NotificationServicesController
property on thestate.engine.backgroundState
Related issues
Fixes: #12207
Manual testing steps
Although we didn't pinpoint what was causing the
NotificationServicesController
to be missing, this code fills in the data if it is missing.Screenshots/Recordings
n/a
Before
n/a
After
n/a
Pre-merge author checklist
Pre-merge reviewer checklist