Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump @metamask/ppom-validator to 0.35.1 #12225

Merged
merged 2 commits into from
Nov 13, 2024
Merged

chore: bump @metamask/ppom-validator to 0.35.1 #12225

merged 2 commits into from
Nov 13, 2024
+13 −82

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Nov 7, 2024 •
edited
Loading

Description

This PR bumps @metamask/ppom-validator to 0.35.1

Related issues

Fixes: #11134

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptodev-2s cryptodev-2s requested review from a team as code owners November 7, 2024 05:58
@cryptodev-2s cryptodev-2s self-assigned this Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s added team-wallet-framework Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: dc6b8a6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c075542a-ef8f-4b3c-817d-59c7a4315c10

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@socket-security Socket Security
Copy link

socket-security bot commented Nov 7, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 122 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-ppom-validator-0.35.1 branch from dc6b8a6 to 880e72e Compare November 7, 2024 06:07
@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-ppom-validator-0.35.1 branch from 880e72e to 8670b68 Compare November 7, 2024 06:13
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8670b68
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f84501f1-a12f-4bcb-9e54-924c7a50dfb1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s mentioned this pull request Nov 7, 2024
Closed
7 tasks
mikesposito
mikesposito approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cryptodev-2s cryptodev-2s added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 09fa44a Nov 13, 2024
37 checks passed
@cryptodev-2s cryptodev-2s deleted the cryptodev2s/bump-ppom-validator-0.35.1 branch November 13, 2024 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tommasini tommasini tommasini approved these changes

@mikesposito mikesposito mikesposito approved these changes

Assignees

@cryptodev-2s cryptodev-2s

Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-wallet-framework
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(deps): Bump @metamask/ppom-validator from 0.32.0 to 0.35.1
4 participants
@cryptodev-2s @mikesposito @tommasini @metamaskbot