Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add unit test for native currency validation #12234

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Nov 7, 2024

Description

Adds unit test coverage for #11693

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner November 7, 2024 20:28
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.36%. Comparing base (9f29292) to head (ec76374).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12234      +/-   ##
==========================================
+ Coverage   55.78%   56.36%   +0.57%     
==========================================
  Files        1786     1786              
  Lines       40362    40390      +28     
  Branches     5054     5063       +9     
==========================================
+ Hits        22516    22764     +248     
+ Misses      16297    16079     -218     
+ Partials     1549     1547       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bergeron bergeron added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 7, 2024
Copy link

sonarcloud bot commented Nov 7, 2024

Copy link
Contributor

@MarioAslau MarioAslau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bergeron bergeron added this pull request to the merge queue Nov 13, 2024
Merged via the queue into main with commit 282cc80 Nov 13, 2024
39 of 40 checks passed
@bergeron bergeron deleted the brian/network-currency-unit-test branch November 13, 2024 16:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.36.0 Issue or pull request that will be included in release 7.36.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants