Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update codeowners #12238

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: update codeowners #12238

wants to merge 2 commits into from

Conversation

sethkfman
Copy link
Contributor

@sethkfman sethkfman commented Nov 7, 2024

Description

Updating codeowners file to remove mobile platform from all files co-owned and removed files from @MetaMask/supply-chain ownership.

This was based on data from the most frequently touched files and cross-team impact.
decoupling_report.csv

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform labels Nov 7, 2024
@sethkfman sethkfman requested a review from a team as a code owner November 7, 2024 23:59
Copy link
Contributor

github-actions bot commented Nov 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Nov 8, 2024

patches/ @MetaMask/mobile-platform
app/core/Engine.ts @MetaMask/mobile-platform
app/core/Engine.test.js @MetaMask/mobile-platform
app/core/Analytics/ @MetaMask/mobile-platform
app/util/metrics/ @MetaMask/mobile-platform
app/components/hooks/useMetrics/ @MetaMask/mobile-platform

# Supply Chain Team
bitrise.yml @MetaMask/supply-chain @MetaMask/mobile-platform
Copy link
Member

@Gudahtt Gudahtt Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend keeping these three under the purview of mobile-platform, so that the mobile platform team gets a chance to review any dependency changes and Bitrise changes. And also so that we are closer to being able to remove mobile-devs completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. team-mobile-platform
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

2 participants