Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update input colors and text formatting #12247

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

amitabh94
Copy link
Contributor

@amitabh94 amitabh94 commented Nov 8, 2024

Description

This PR updates the staking UI components and text to improve visual consistency and clarity:

  • Updated input text color from muted to deafult in both stake and unstake input views for better readability
  • Simplified text color logic in InputDisplay by removing conditional coloring based on amount
  • Enhanced unstaking tooltip text to be more precise

Related issues

Fixes: STAKE-863

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amitabh94 amitabh94 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5453872
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/57950007-e146-4558-9072-28669cf01749

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@amitabh94 amitabh94 changed the title style: update input colors and text formatting feat: update input colors and text formatting Nov 8, 2024
@amitabh94 amitabh94 marked this pull request as ready for review November 8, 2024 21:18
@amitabh94 amitabh94 requested review from a team as code owners November 8, 2024 21:18
Copy link
Contributor

@Matt561 Matt561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Nov 8, 2024

Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It would be good if we have a screenshot of the changes on the PR description!

@amitabh94 amitabh94 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit f7920d8 Nov 12, 2024
63 of 66 checks passed
@amitabh94 amitabh94 deleted the fix/staking-fixes branch November 12, 2024 16:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
@gauthierpetetin gauthierpetetin added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants