Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add migration to fix NotificationServicesController bug (#12219) #12250

Merged
merged 3 commits into from
Nov 12, 2024

Commits on Nov 8, 2024

  1. fix: Add migration to fix NotificationServicesController bug (#12219)

    <!--
    Please submit this PR as a draft initially.
    Do not mark it as "Ready for review" until the template has been
    completely filled out, and PR status checks have passed at least once.
    -->
    
    The purpose of this PR is to fix an error apparently caused by a missing
    `NotificationServicesController` property on the
    `state.engine.backgroundState`
    
    Fixes: #12207
    
    Although we didn't pinpoint what was causing the
    `NotificationServicesController` to be missing, this code fills in the
    data if it is missing.
    
    n/a
    
    n/a
    
    n/a
    
    - [ ] I’ve followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
    Coding
    Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
    - [ ] I've completed the PR template to the best of my ability
    - [ ] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [ ] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    
    ---------
    
    Co-authored-by: sethkfman <[email protected]>
    kylanhurt and sethkfman committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    24d6cee View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5fcc197 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    83244c2 View commit details
    Browse the repository at this point in the history