Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multi chain list and network filter (experimental) #12256

Draft
wants to merge 172 commits into
base: main
Choose a base branch
from

Conversation

vinnyhoward
Copy link
Contributor

@vinnyhoward vinnyhoward commented Nov 11, 2024

Description

This PR is experimental, the real PR is here

The feature is currently hidden under a feature flag PORTFOLIO_VIEW to run and test run PORTFOLIO_VIEW=true yarn watch. Currently the app will crash without the necessary controller updates or patches

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

NA

Before

NA

After

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

gambinish and others added 30 commits September 26, 2024 17:09
…/metamask-mobile into chore/componetize-tokens-screen
@vinnyhoward vinnyhoward changed the title feat: multi chain network filter feat: multi chain network filter (experimental) Nov 13, 2024
@vinnyhoward vinnyhoward changed the title feat: multi chain network filter (experimental) feat: multi chain list and network filter (experimental) Nov 13, 2024
Copy link

socket-security bot commented Nov 15, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] Transitive: network +4 3.2 MB danfinlay, gudahtt, kumavis, ...7 more

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO-NOT-MERGE Pull requests that should not be merged No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants