Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove global network usage from petnames #12257

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 11, 2024

Description

Remove all usage of the global network from the Name component and related display name hooks.

Specifically:

  • Remove usages of the selectChainId selector.
  • Require variation property in Name component and useDisplayName hook.
  • Add linting rule to prevent future usage of any global network selectors.
  • Add imageUri property to Identicon component.
  • Add chainId property to Address component.
  • Rename useTokenListEntry hook to useERC20Tokens.
  • Add selectERC20TokensByChain selector.
  • Remove useTokenList hook.

Related issues

Fixes: #1987

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Nov 11, 2024
@matthewwalsh0 matthewwalsh0 requested review from a team as code owners November 11, 2024 09:32
@matthewwalsh0 matthewwalsh0 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 11, 2024
Copy link
Contributor

github-actions bot commented Nov 11, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b4222b3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a2d7bb7f-4640-4914-a31f-638e65126428

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner November 11, 2024 10:15
Copy link

socket-security bot commented Nov 11, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 8.85 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

Copy link

sonarcloud bot commented Nov 12, 2024

.eslintrc.js Show resolved Hide resolved
@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 12, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b3d8184
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/973b3229-e437-4026-9612-a64b5151dcc7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@matthewwalsh0 matthewwalsh0 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 12, 2024
@matthewwalsh0 matthewwalsh0 added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit c5cdca9 Nov 15, 2024
60 of 61 checks passed
@matthewwalsh0 matthewwalsh0 deleted the refactor/remove-global-network-usage-petnames branch November 15, 2024 11:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants