-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Salim/multi chain token rate and balances #12260
Draft
salimtb
wants to merge
148
commits into
main
Choose a base branch
from
salim/multi-chain-token-rate-and-balances
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,695
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/metamask-mobile into chore/componetize-tokens-screen
…Mask/metamask-mobile into feat/mmassets-431_network-filter-ui
…Mask/metamask-mobile into feat/mmassets-431_network-filter-ui
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gambinish
reviewed
Nov 12, 2024
salimtb
force-pushed
the
salim/multi-chain-token-rate-and-balances
branch
from
November 12, 2024 17:29
7180e6f
to
0a067d6
Compare
…Mask/metamask-mobile into feat/mmassets-431_network-filter-ui
This is the release candidate for version 7.34.0 # Team sign-off checklist - [ ] team-accounts - [ ] team-assets - [x] team-confirmations - [x] team-design-system - [ ] team-lavamoat - [x] team-mobile-platform - [x] team-notifications - [x] team-ramp - [ ] team-sdk - [ ] team-security - [x] team-snaps-platform - [x] team-stake - [ ] team-tiger - [ ] team-wallet-framework - [ ] team-wallet-ux # Reference - Testing plan sheet - https://docs.google.com/spreadsheets/d/1tsoodlAlyvEUpkkcNcbZ4PM9HuC9cEM80RZeoVv5OCQ/edit?gid=404070372#gid=404070372 --------- Signed-off-by: Kai Huang <[email protected]> Co-authored-by: runway-github[bot] <73448015+runway-github[bot]@users.noreply.github.com> Co-authored-by: MetaMask Bot <[email protected]> Co-authored-by: metamaskbot <[email protected]> Co-authored-by: tommasini <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Xiaoming Wang <[email protected]> Co-authored-by: Nico MASSART <[email protected]> Co-authored-by: Xiaoming Wang <[email protected]> Co-authored-by: Nicholas Ellul <[email protected]> Co-authored-by: legobt <[email protected]> Co-authored-by: OGPoyraz <[email protected]> Co-authored-by: Salim TOUBAL <[email protected]> Co-authored-by: Pedro Pablo Aste Kompen <[email protected]> Co-authored-by: legobeat <[email protected]> Co-authored-by: tommasini <[email protected]> Co-authored-by: Bryan Fullam <[email protected]> Co-authored-by: Mpendulo Ndlovu <[email protected]> Co-authored-by: Kaihuang72490 <[email protected]> Co-authored-by: Cal-L <[email protected]> Co-authored-by: Cal Leung <[email protected]> Co-authored-by: sahar-fehri <[email protected]> Co-authored-by: Vince Howard <[email protected]> Co-authored-by: Matthew Walsh <[email protected]>
…hain-token-rate-and-balances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Screen.Recording.2024-11-12.at.15.43.43.mov
Pre-merge author checklist
Pre-merge reviewer checklist