Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update remaining trackevent calls #12267

Draft
wants to merge 1 commit into
base: fix/12117_trackevent_enabled_undefined
Choose a base branch
from

Conversation

NicolasMassart
Copy link
Contributor

@NicolasMassart NicolasMassart commented Nov 12, 2024

Description

This is a follow up PR for #12180 which still have some files left to update.
This PR branch is based on the branch fix/12117_trackevent_enabled_undefined to continue the work.

Related issues

Fixes #12262

Manual testing steps

  1. Try actions and see if it sends a metrics event

Screenshots/Recordings

Before

Files left to update for this PR
image

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@NicolasMassart NicolasMassart changed the base branch from main to fix/12117_trackevent_enabled_undefined November 13, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: update the remaining trackEvent calls to use new builder pattern
2 participants