Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multichain currency rate polling #12268

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Nov 12, 2024

Description

This PR uses the CurrencyRateController to poll native currency prices across chains. This will keep prices updated in state across all networks.

Because we're polling across all networks, it's no longer necessary to trigger updates when switching chains, so these places have been removed. Once we start showing tokens across all networks, "switching chains" will become a less relevant action.

Related issues

Manual testing steps

  1. Verify fiat prices are correct for the native currency on a network
  2. Switch to a network with a different native currency,
  3. Verify fiat prices are correct for that network

Screenshots/Recordings

Before

After

No visual changes, but native token prices should still be accurate across networks and when changing currencies.

Screen.Recording.2024-11-14.at.9.55.13.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested review from a team as code owners November 12, 2024 21:38
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron requested a review from a team as a code owner November 12, 2024 21:59
Copy link

sonarcloud bot commented Nov 12, 2024

@bergeron bergeron added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 12, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2e9dff3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f93ecf08-0de3-45d1-af18-6d47026e42ab

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@bergeron bergeron added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 13, 2024
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS looks very good! Can we have some recordings of this? (Like switching between accounts and currencies)
I will approve but it's good to have recordings of this on the PR description!

@bergeron bergeron added this pull request to the merge queue Nov 14, 2024
@bergeron
Copy link
Contributor Author

Can we have some recordings of this

added to PR description

Merged via the queue into main with commit 2792684 Nov 14, 2024
47 of 48 checks passed
@bergeron bergeron deleted the brian/multichain-currency-rate-polling branch November 14, 2024 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants