-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multichain currency rate polling #12268
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Bitrise✅✅✅ Commit hash: 2e9dff3 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THIS looks very good! Can we have some recordings of this? (Like switching between accounts and currencies)
I will approve but it's good to have recordings of this on the PR description!
added to PR description |
Description
This PR uses the
CurrencyRateController
to poll native currency prices across chains. This will keep prices updated in state across all networks.Because we're polling across all networks, it's no longer necessary to trigger updates when switching chains, so these places have been removed. Once we start showing tokens across all networks, "switching chains" will become a less relevant action.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
No visual changes, but native token prices should still be accurate across networks and when changing currencies.
Screen.Recording.2024-11-14.at.9.55.13.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist