-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade assets controllers to 42 with multichain token rates #12270
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected] |
Bitrise✅✅✅ Commit hash: 4a77428 Note
|
Bitrise✅✅✅ Commit hash: 662797c Note
|
Quality Gate passedIssues Measures |
Description
This PR upgrades asset controllers to 42. This version contains
resetState
functions in controllers, so it no longer needs to be patched. It also allows us to poll erc20 token rates across chains.Related issues
Manual testing steps
With PORTFOLIO_VIEW=false and PORTFOLIO_VIEW=true:
Screenshots/Recordings
Before
After
No visual changes. erc20 prices should be correct when adding tokens, switching networks, and switching currencies.
Screen.Recording.2024-11-14.at.12.58.29.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist