Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade assets controllers to 42 with multichain token rates #12270

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Nov 13, 2024

Description

This PR upgrades asset controllers to 42. This version contains resetState functions in controllers, so it no longer needs to be patched. It also allows us to poll erc20 token rates across chains.

Related issues

Manual testing steps

With PORTFOLIO_VIEW=false and PORTFOLIO_VIEW=true:

  1. Import some erc20 tokens
  2. Verify erc20 token prices are correct
  3. Switch chains
  4. Verify erc20 token prices are correct
  5. In settings, change the fiat currency
  6. Verify erc20 token prices are correct

Screenshots/Recordings

Before

After

No visual changes. erc20 prices should be correct when adding tokens, switching networks, and switching currencies.

Screen.Recording.2024-11-14.at.12.58.29.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested review from a team as code owners November 13, 2024 01:49
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Nov 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None +4 3.03 MB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

Base automatically changed from brian/multichain-currency-rate-polling to main November 14, 2024 18:01
@github-actions github-actions bot requested review from a team as code owners November 14, 2024 18:01
@bergeron bergeron added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4a77428
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0417fa57-0de2-46e9-bd12-df7eb88af72b

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

vinnyhoward
vinnyhoward previously approved these changes Nov 14, 2024
@bergeron bergeron removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 15, 2024
@bergeron bergeron added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 15, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 662797c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7b8281ee-7ca1-454d-bcd4-0a0ed00f3b50

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarcloud bot commented Nov 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants