Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update naming for returning a txHash asap for smart transactions #12274

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Nov 13, 2024

Description

This PR updates naming for returning a txHash asap and also merges shared feature flags for smart transactions with network specific ones.

Related issues

Fixes:

Manual testing steps

  1. Once the new feature flag is enabled on backend, the mobile app will return a txHash asap after submitting a transaction.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 added the team-transactions Transactions team label Nov 13, 2024
@dan437 dan437 requested a review from a team as a code owner November 13, 2024 12:56
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dan437 dan437 changed the title chore: update naming for returning a txHash asap for smart transactions chore: Update naming for returning a txHash asap for smart transactions Nov 13, 2024
klejeune
klejeune previously approved these changes Nov 13, 2024
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run e2e for this.

@dan437 dan437 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 14, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 8bf0284
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1d2ceb49-78db-467e-8778-dc494793b167

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@chrisleewilcox chrisleewilcox dismissed their stale review November 14, 2024 19:19

E2E passed, the notify failed for some reason.

Copy link

sonarcloud bot commented Nov 15, 2024

@dan437 dan437 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 15, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 83079b5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fc585f50-ed0c-4fd5-a1fc-3c7c293896a0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@dan437 dan437 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 15, 2024
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan437 dan437 added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit d3d26da Nov 15, 2024
49 checks passed
@dan437 dan437 deleted the return-tx-hash-asap branch November 15, 2024 17:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
@metamaskbot metamaskbot added the release-7.37.0 Issue or pull request that will be included in release 7.37.0 label Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.37.0 Issue or pull request that will be included in release 7.37.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-transactions Transactions team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants