-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update naming for returning a txHash asap for smart transactions #12274
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
b3fdaba
to
b0afb12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run e2e for this.
Bitrise🔄🔄🔄 Commit hash: 8bf0284 Note
|
E2E passed, the notify failed for some reason.
8bf0284
to
83079b5
Compare
Quality Gate passedIssues Measures |
Bitrise✅✅✅ Commit hash: 83079b5 Note
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR updates naming for returning a txHash asap and also merges shared feature flags for smart transactions with network specific ones.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist