Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loading skeleton for staking banners #12280

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

amitabh94
Copy link
Contributor

@amitabh94 amitabh94 commented Nov 13, 2024

Description

This PR adds a loading component for the time when pooled stakes data is being fetched before being rendered to the user to avoid abrupt pop in of banners on the screen and make the UI experience smoother.

Related issues

Fixes: STAKE-854

Manual testing steps

  1. Set export MM_POOLED_STAKING_UI_ENABLED=true in your local .js.env file
  2. From the asset list page, click Ethereum
  3. You will see a loading skeleton before the staking banners appear.

Screenshots/Recordings

Before

Without_Loading_Skeleton.mp4

After

With_loading_skeleton.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@amitabh94 amitabh94 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 13, 2024
Copy link
Contributor

github-actions bot commented Nov 13, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e64ab09
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0ea5fd39-f726-4909-b515-066b1cd57f90

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@amitabh94 amitabh94 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 13, 2024
@amitabh94 amitabh94 marked this pull request as ready for review November 13, 2024 19:57
@amitabh94 amitabh94 requested a review from a team as a code owner November 13, 2024 19:57
Copy link
Contributor

@Matt561 Matt561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sethkfman sethkfman added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 13, 2024
@amitabh94 amitabh94 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: b6a4617
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fcdf65d4-f0d8-4525-a82f-dc6b119d74f5

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarcloud bot commented Nov 14, 2024

@amitabh94 amitabh94 added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit ba7c2cc Nov 14, 2024
42 of 43 checks passed
@amitabh94 amitabh94 deleted the STAKE-854-add-loading-skeleton branch November 14, 2024 05:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-stake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants