Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lock ruby version to 3.1.6 and bump pod to 1.16.2 #12282

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Conversation

Cal-L
Copy link
Contributor

@Cal-L Cal-L commented Nov 13, 2024

Description

This bumps and locks pod version to 1.16.2. It also locks ruby to 3.1.6

Related issues

Fixes:

Manual testing steps

  1. Run yarn setup
  2. Steps should be successful
  3. App should run normally

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Cal-L Cal-L requested review from a team as code owners November 13, 2024 22:18
@Cal-L Cal-L added team-mobile-platform Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 13, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 13, 2024
Copy link

socket-security bot commented Nov 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
gem/[email protected] environment, eval, filesystem, network, shell, unsafe +33 14.4 MB

🚮 Removed packages: gem/[email protected]

View full report↗︎

Copy link

socket-security bot commented Nov 13, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Shell access gem/[email protected] 🚫
Network access gem/[email protected] 🚫
Shell access gem/[email protected] 🚫
Shell access gem/[email protected] 🚫
Network access gem/[email protected] 🚫
Shell access gem/[email protected] 🚫
Shell access gem/[email protected] 🚫
Network access gem/[email protected] 🚫
Shell access gem/[email protected] 🚫
Network access gem/[email protected] 🚫
Shell access gem/[email protected] 🚫
Shell access gem/[email protected] 🚫

View full report↗︎

Next steps

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link
Contributor

github-actions bot commented Nov 13, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1e22391
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f1f3836a-f85b-4ef0-acfd-cbbfca0703d9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@Cal-L Cal-L changed the title fix: Bump pods to 1.16.2 fix: Lock ruby version to 3.1.6 and bump pod to 1.16.2 Nov 14, 2024
Copy link

sonarcloud bot commented Nov 14, 2024

@Cal-L Cal-L enabled auto-merge November 14, 2024 00:45
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 40d2353 Nov 14, 2024
35 of 37 checks passed
@Cal-L Cal-L deleted the fix/bump-pods-1.16.2 branch November 14, 2024 01:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 14, 2024
@metamaskbot metamaskbot added the release-7.36.0 Issue or pull request that will be included in release 7.36.0 label Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No QA Needed Apply this label when your PR does not need any QA effort. release-7.36.0 Issue or pull request that will be included in release 7.36.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants