refactor: remove global network from transaction controller

[matthewwalsh0]

Include network client ID in addTransaction calls. Include network client ID in updateIncomingTransactions calls. Include network client Id in getNetworkNonce calls. Update calls to wipeTransactions.
Create global network utils.
Move getGlobalEthQuery to global network utils.
Add network client ID to test data.

Description

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7bc1d9b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1a637aa0-f67f-4e36-a6b8-a3fbe0875e45

Note

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

• Check the documentation if you have any doubts on how to understand the failure on bitrise

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	network	0	264 kB	metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

[sonarcloud]

Quality Gate failed

Failed conditions
57.3% Coverage on New Code (required ≥ 60%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE