fix: Make ResponseWrapper an instance of Response
#2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 486 486
Lines 10397 10399 +2
Branches 1594 1594
=======================================
+ Hits 9824 9826 +2
Misses 573 573 ☔ View full report in Codecov by Sentry. |
FrederikBolding
commented
Nov 15, 2024
| @@ -7,7 +7,7 @@ import type { EndowmentFactoryOptions } from './commonEndowmentFactory'; | |||
| * This class wraps a Response object. | |||
| * That way, a teardown process can stop any processes left. | |||
| */ | |||
| class ResponseWrapper implements Response { | |||
| export class ResponseWrapper extends Response { | |||
There was a problem hiding this comment.
Devs can still access the underlying Response by using the prototype chain. We'll need to fix that before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
ResponseWrapperextendResponseso thatinstanceofchecks do not fail on responses fromfetch.