Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

devDeps(test): replace ethereumjs-util with @ethereumjs/util,ethereum-cryptography #457

Merged
merged 1 commit into from
Oct 20, 2023
Merged

devDeps(test): replace ethereumjs-util with @ethereumjs/util,ethereum-cryptography #457

merged 1 commit into from
Oct 20, 2023

Conversation

legobeat
Copy link
Collaborator

@legobeat legobeat commented Oct 18, 2023 •
edited
Loading

  • ethereum-cryptography already implicitly pulled in via runtime dependency @ethereumjs/statemanager. Making it explicit here
  • ethereumjs-util was replaced with @ethereumjs/util as runtime dependency in deps: Bump ethereumjs and metamask packages #453

@legobeat legobeat marked this pull request as ready for review October 18, 2023 02:39
@legobeat legobeat requested a review from a team as a code owner October 18, 2023 02:39
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Oct 18, 2023
mcmire
mcmire approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@legobeat legobeat merged commit d5da4c8 into MetaMask:main Oct 20, 2023
5 checks passed
@legobeat legobeat deleted the devdeps-test-ethereumjs-util branch October 20, 2023 00:34
@legobeat legobeat restored the devdeps-test-ethereumjs-util branch October 20, 2023 00:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mcmire mcmire mcmire approved these changes

@kumavis kumavis Awaiting requested review from kumavis

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @mcmire