Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added height and width props to Twitch service #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crutchcorn
Copy link

What: Add the ability to pass custom height and width to Twitch embeds

Why: Consumers of plugin may need to customize the height of the embed (such as my project)

How: Add option to render function, added tests, updated documentation

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

Related issue: #144
Related PR: #151

I'd be happy to add this logic to every other service with hardcoded options if that would be helpful for the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant