updated 'deploy-gpu-node-pool.md' with instructions for using Headless OS #3171

mgodfre3 · 2024-06-11T14:16:37Z

The instructions for uninstalling drivers was written for a Desktop Experience Server, not Azure Stack HCI, which is intended OS, I updated docs to include PowerShell examples.

prmerger-automator · 2024-06-11T14:16:49Z

@mgodfre3 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

learn-build-service-prod · 2024-06-11T14:19:10Z

Learn Build status updates of commit 0018650:

✅ Validation status: passed

File	Status	Preview URL	Details
AKS-Hybrid/deploy-gpu-node-pool.md	✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

Court72 · 2024-06-11T15:38:36Z

@sethmanheim

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

learn-build-service-prod · 2024-06-11T15:50:04Z

Learn Build status updates of commit 412c583:

✅ Validation status: passed

File	Status	Preview URL	Details
AKS-Hybrid/deploy-gpu-node-pool.md	✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

learn-build-service-prod · 2024-06-11T15:52:51Z

Learn Build status updates of commit 03d48f0:

✅ Validation status: passed

File	Status	Preview URL	Details
AKS-Hybrid/deploy-gpu-node-pool.md	✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

JamesLiang29 · 2024-06-20T03:15:06Z

AKS-Hybrid/deploy-gpu-node-pool.md

+Run the following command in your Powershell session, and replace `.\oem1.inf` with the value in **Published Name** from the previous **PNPUTIL Enum-Devices** output:
+
+```powershell
+pnputil /delete-driver .\oem1.inf /uninstall /reboot


We'd better replace .\oem1.inf to something like <oem#.inf>, avoiding someone copy, paste, run without noticing your guideline above.

I call this out on line 89 and suggest that you replace the value with a value from the output.

Yes. But oem1.inf is a real driver. If someone just copy, paste and run without replacing the value, a driver will be removed unexpectedly. By given <oem#.inf> in sample code, the command with fail with noop to system. It's safer.

JamesLiang29 · 2024-06-20T03:21:56Z

AKS-Hybrid/deploy-gpu-node-pool.md

@@ -82,7 +107,8 @@ When you uninstall the host driver, the physical GPU goes into an error state. Y
 For each GPU (3D Video Controller) device, run the following commands in PowerShell. Copy the instance ID; for example, `PCI\VEN_10DE&DEV_1EB8&SUBSYS_12A210DE&REV_A1\4&32EEF88F&0&0000` from the previous command output:

 ```powershell
-$id1 = "<Copy and paste GPU instance id into this string>"
+$gpu=Get-PnpDevice -FriendlyName "3D Video Controller"
+$id1 =$gpu[0].InstanceId


These works for single GPU device. But if there're multiple GPU installed on one host, we need a loop. Moreover, end users may want to choose to setup some, but not all of devices.

This is called out on line 107 with the statement "For Each GPU...., run the following commands in Powershell." Do we need to make it even more clear?

In line 110 the $gpu gets all devices named as "3D Video Controller", so in line 111 the $id1 will always be set to the instance id of the first GPU device.

Karl-WE

Would it be possible to avoid mix and match legacy shell commands with PowerShell?
See line 73 piping to findstr. I am no expert but believe PowerShell can do this natively.

Any idea @JamesLiang29 ?

JamesLiang29 · 2024-06-20T09:51:13Z

Would it be possible to avoid mix and match legacy shell commands with PowerShell? See line 73 piping to findstr. I am no expert but believe PowerShell can do this natively.

Any idea @JamesLiang29 ?

Get-PnpDevice | Where-Object FriendlyName -Like '3D Video*' | Select-Object Status, FriendlyName, InstanceId

Karl-WE · 2024-06-20T18:59:47Z

I was asking for your help as I cannot test the result.

Would you mind to create a request for change of line 74?

mgodfre3 · 2024-06-21T17:45:05Z

Added the requested changes and added a new GPU command for additional GPUs.

learn-build-service-prod · 2024-06-21T17:46:12Z

Learn Build status updates of commit ca8cf70:

✅ Validation status: passed

File	Status	Preview URL	Details
AKS-Hybrid/deploy-gpu-node-pool.md	✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

sethmanheim · 2024-06-21T17:47:34Z

AKS-Hybrid/deploy-gpu-node-pool.md

@@ -104,11 +104,21 @@ Error       3D Video Controller                   PCI\VEN_10DE&DEV_1EB8&SUBSYS_1

 When you uninstall the host driver, the physical GPU goes into an error state. You must dismount all the GPU devices from the host.

-For each GPU (3D Video Controller) device, run the following commands in PowerShell. Copy the instance ID; for example, `PCI\VEN_10DE&DEV_1EB8&SUBSYS_12A210DE&REV_A1\4&32EEF88F&0&0000` from the previous command output:
+For each GPU (3D Video Controller) device, run the following commands in PowerShell. This command will create a variable named "ID1" and "lp1" and populate the instance ID of the first GPU; for example, `PCI\VEN_10DE&DEV_1EB8&SUBSYS_12A210DE&REV_A1\4&32EEF88F&0&0000` from the previous command output. 


Suggested change

For each GPU (3D Video Controller) device, run the following commands in PowerShell. This command will create a variable named "ID1" and "lp1" and populate the instance ID of the first GPU; for example, `PCI\VEN_10DE&DEV_1EB8&SUBSYS_12A210DE&REV_A1\4&32EEF88F&0&0000` from the previous command output.

For each GPU (3D Video Controller) device, run the following commands in PowerShell. This command creates variables named `ID1` and `lp1` and populates the instance ID of the first GPU; for example, `PCI\VEN_10DE&DEV_1EB8&SUBSYS_12A210DE&REV_A1\4&32EEF88F&0&0000` from the previous command output.

AKS-Hybrid/deploy-gpu-node-pool.md

Co-authored-by: Seth Manheim <[email protected]>

learn-build-service-prod · 2024-06-21T17:53:30Z

Learn Build status updates of commit 8da0cdd:

✅ Validation status: passed

File	Status	Preview URL	Details
AKS-Hybrid/deploy-gpu-node-pool.md	✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

JamesLiang29 · 2024-06-21T17:53:47Z

AKS-Hybrid/deploy-gpu-node-pool.md

+Open an elevated PowerShell prompt and run the following command:
+
+```powershell
+Get-PnpDevice | Where-Object FriendlyName -Like '3D Video*' | Select-Object Status, FriendlyName, InstanceId 
+```
+


Could you please move these lines (L71-76) to that between L95 and L96.

JamesLiang29 · 2024-06-21T17:55:47Z

AKS-Hybrid/deploy-gpu-node-pool.md

+$id0 =$gpu[0].InstanceId
+$lp0 = (Get-PnpDeviceProperty -KeyName DEVPKEY_Device_LocationPaths -InstanceId $id1).Data[0]


You renamed the variables to $id0 and $lp0 here, but subsequence lines (112-114) are still using $id1 and $lp1.

i see the issue, quick fix.

learn-build-service-prod · 2024-06-21T18:06:55Z

Learn Build status updates of commit 0557b31:

✅ Validation status: passed

File	Status	Preview URL	Details
AKS-Hybrid/deploy-gpu-node-pool.md	✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

learn-build-service-prod · 2024-06-21T18:10:20Z

Learn Build status updates of commit b447080:

✅ Validation status: passed

File	Status	Preview URL	Details
AKS-Hybrid/deploy-gpu-node-pool.md	✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Try searching the learn.microsoft.com contributor guides
Post your question in the Learn support channel

updated 'deploy-gpu-node-pool.md' with instuctions for using Headless OS

0018650

prmerger-automator bot added the do-not-merge label Jun 11, 2024

prmerger-automator bot requested a review from sethmanheim June 11, 2024 14:16

prmerger-automator bot assigned sethmanheim Jun 11, 2024

prmerger-automator bot added aks-hci/subsvc azure-stack/svc Change sent to author labels Jun 11, 2024

prmerger-automator bot added the qualifies-for-auto-merge label Jun 11, 2024

prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jun 11, 2024

Update deploy-gpu-node-pool.md

412c583

prmerger-automator bot removed the qualifies-for-auto-merge label Jun 11, 2024

sethmanheim added 2 commits June 11, 2024 08:47

Update deploy-gpu-node-pool.md

03d48f0

Update deploy-gpu-node-pool.md

0c06663

prmerger-automator bot added qualifies-for-auto-merge and removed qualifies-for-auto-merge labels Jun 11, 2024

prmerger-automator bot added the qualifies-for-auto-merge label Jun 11, 2024

Naveenommi-MSFT added the triaged label Jun 12, 2024

JamesLiang29 suggested changes Jun 20, 2024

View reviewed changes

Karl-WE suggested changes Jun 20, 2024

View reviewed changes

made suggested changes

ca8cf70

prmerger-automator bot removed the qualifies-for-auto-merge label Jun 21, 2024

prmerger-automator bot added the qualifies-for-auto-merge label Jun 21, 2024

sethmanheim reviewed Jun 21, 2024

View reviewed changes

AKS-Hybrid/deploy-gpu-node-pool.md Outdated Show resolved Hide resolved

Update AKS-Hybrid/deploy-gpu-node-pool.md

8da0cdd

Co-authored-by: Seth Manheim <[email protected]>

prmerger-automator bot removed the qualifies-for-auto-merge label Jun 21, 2024

prmerger-automator bot added the qualifies-for-auto-merge label Jun 21, 2024

JamesLiang29 reviewed Jun 21, 2024

View reviewed changes

made suggestion from JameLiang29

0557b31

prmerger-automator bot removed the qualifies-for-auto-merge label Jun 21, 2024

corrected lines 113-118

b447080

prmerger-automator bot added qualifies-for-auto-merge and removed qualifies-for-auto-merge labels Jun 21, 2024

prmerger-automator bot added the qualifies-for-auto-merge label Jun 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updated 'deploy-gpu-node-pool.md' with instructions for using Headless OS #3171

updated 'deploy-gpu-node-pool.md' with instructions for using Headless OS #3171

mgodfre3 commented Jun 11, 2024

prmerger-automator bot commented Jun 11, 2024

learn-build-service-prod bot commented Jun 11, 2024

Court72 commented Jun 11, 2024

learn-build-service-prod bot commented Jun 11, 2024

learn-build-service-prod bot commented Jun 11, 2024

JamesLiang29 Jun 20, 2024

mgodfre3 Jun 20, 2024

JamesLiang29 Jun 21, 2024

JamesLiang29 Jun 20, 2024

mgodfre3 Jun 20, 2024

JamesLiang29 Jun 21, 2024

Karl-WE left a comment •

edited

Loading

JamesLiang29 commented Jun 20, 2024

Karl-WE commented Jun 20, 2024

mgodfre3 commented Jun 21, 2024

learn-build-service-prod bot commented Jun 21, 2024

sethmanheim Jun 21, 2024

learn-build-service-prod bot commented Jun 21, 2024

JamesLiang29 Jun 21, 2024

JamesLiang29 Jun 21, 2024

mgodfre3 Jun 21, 2024

learn-build-service-prod bot commented Jun 21, 2024

learn-build-service-prod bot commented Jun 21, 2024

	For each GPU (3D Video Controller) device, run the following commands in PowerShell. This command will create a variable named "ID1" and "lp1" and populate the instance ID of the first GPU; for example, `PCI\VEN_10DE&DEV_1EB8&SUBSYS_12A210DE&REV_A1\4&32EEF88F&0&0000` from the previous command output.
	For each GPU (3D Video Controller) device, run the following commands in PowerShell. This command creates variables named `ID1` and `lp1` and populates the instance ID of the first GPU; for example, `PCI\VEN_10DE&DEV_1EB8&SUBSYS_12A210DE&REV_A1\4&32EEF88F&0&0000` from the previous command output.

		$id0 =$gpu[0].InstanceId
		$lp0 = (Get-PnpDeviceProperty -KeyName DEVPKEY_Device_LocationPaths -InstanceId $id1).Data[0]

updated 'deploy-gpu-node-pool.md' with instructions for using Headless OS #3171

Are you sure you want to change the base?

updated 'deploy-gpu-node-pool.md' with instructions for using Headless OS #3171

Conversation

mgodfre3 commented Jun 11, 2024

prmerger-automator bot commented Jun 11, 2024

learn-build-service-prod bot commented Jun 11, 2024

✅ Validation status: passed

Court72 commented Jun 11, 2024

learn-build-service-prod bot commented Jun 11, 2024

✅ Validation status: passed

learn-build-service-prod bot commented Jun 11, 2024

✅ Validation status: passed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Karl-WE left a comment • edited Loading

Choose a reason for hiding this comment

JamesLiang29 commented Jun 20, 2024

Karl-WE commented Jun 20, 2024

mgodfre3 commented Jun 21, 2024

learn-build-service-prod bot commented Jun 21, 2024

✅ Validation status: passed

Choose a reason for hiding this comment

learn-build-service-prod bot commented Jun 21, 2024

✅ Validation status: passed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

learn-build-service-prod bot commented Jun 21, 2024

✅ Validation status: passed

learn-build-service-prod bot commented Jun 21, 2024

✅ Validation status: passed

Karl-WE left a comment •

edited

Loading