RoR Capstone Project - Budget App

[cherelemma]

Hello Dear CR ✋

I hope this message finds you well. I am submitting a pull request for your review and feedback on the implementation of the RoR Capstone project. I implemented the project requirements and ensure comprehensive test coverage. Also, I maintained the general requirements.

Project Requirements

Design

• Should follow these design guidelines, including:
  • Colors.
  • Typography: font face, size and weight.
  • Layout: composition and space between elements.

NOTE: In these design guidelines there are several UIs that you won't need for this exercise; also, some pages are not given a design and you will create them following the design guidelines of the other pages.

Original design idea by Gregoire Vella on Behance.

The Creative Commons license of the design requires that you give appropriate credit to the author. Therefore, you must do it in the README of your project.

Interactions

• Splash screen

  • A simple page with the name of your app (yes, you need to choose one), and links to the sign up and log in pages.

• Sign up and log in pages

  • The user should be able to register in the app with full name, email and password (all mandatory).
  • The user can log into the app using email and password.
  • If the user is not logged in, they can't access pages that require the user to be logged in (all the pages described below).

• Home page (categories page)

  • When the user logs in, they are presented with the categories page.
  • For each category, the user can see their name, icon and the total amount of all the transactions that belongs to that category.
  • When the user clicks (or taps) on a category item, the application navigates to the transactions page for that category.
  • There is a button "add a new category" at the bottom that brings the user to the page to create a new category.

• Transactions page

  • For a given category, the list of transactions is presented, ordered by the most recent.
  • At the top of the page the user could see the total amount for the category (sum of all of the amounts of the transactions in that category).
  • There is a button "add a new transaction" at the bottom that brings the user to the page to create a new transaction.
  • When the user clicks on the "Back" button (<), the user navigates to the home page.

• "Add a new category" page

  • The user fills out a form to create a new category, indicating their name and icon (both mandatory).
  • The user clicks (or taps) the "Save" button to create the new category, and is taken to the home page on success.
  • When the user clicks on the "Back" button (<), the user navigates to the home page.

• "Add a new transaction" page

  • The user fills out a form to create a new transaction with:
    • name (mandatory)
    • amount (mandatory)
    • categories (mandatory at least one)
  • The user click (or taps) the "Save" button to create the new transaction, and is taken to the transactions page for that category.
  • When the user clicks on the "Back" button (<), the user navigates to the transactions page for that category.

Testing requirements

• Create unit and integration tests for all the most important components of your RoR application.

Technical requirements

• You should use Postgres as your database.
• You should use devise for authentication.
• You should validate all user input to make sure that anyone with bad intentions cannot compromise your app.
• You can use a view template engine of your choice (.erb, .slim, .haml).
• The project should be deployed and accessible online.
• Your database schema should reflect the following structure:

NOTE: do not change column names visible in the diagram. You need to change the "Entity" name according to the theme you have chosen for your project (please note: "Transaction" is a name already used by ActiveRecord, so using it as a name for your model and table will result in an error).

General Requirements

• There are No linter errors
• Follow correct GitFlow
• Follow the list of best practices for Ruby.
• Document my work in a professional way.

[prolajumokeoni]

Hi @cherelemma

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that does not follow proper Gitlow, please check the general requirements 👍🏿

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

Invalid Code Review Request does not count into the code reviews limit.

[zieeco]

Hi @cherelemma,

Great job so far! 👏
You've done well, however, there are some issues that you still need to work on to go to the next project, but you are almost there!

To highlight 🎯

• No linter errors.✔️
• Nice design. ✔️
• Descriptive PR. ✔️

Required Changes ♻️

Check the comments under the review.

Optional suggestions

• N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

[zieeco]

Hi @cherelemma,

Great job so far implementing the changes! 👏
You've done well, however, there are some issues that you still need to work on to go to the next project, but you are almost there!

To highlight 🎯

• No linter errors.✔️
• Nice design. ✔️
• Descriptive PR. ✔️

Required Changes ♻️

Check the comments under the review.

Optional suggestions

• N/A

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

[Whoistolu]

Hi @cherelemma

Your project is complete! There is nothing else to say other than... it's time to merge it

STATUS: APPROVED 🟢

Congratulations! 🎉

• Check the inline comments under the review for sections to improve.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

• [OPTIONAL] Kindly note that the correct Gitflow for:
• Solo capstone projects: the flow for requesting reviews is Gitflow which means feature branch merging to dev
• Group capstone projects: the correct flow for requesting reviews is Github flow which means dev merging to main.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Whoistolu in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.