RoR Capstone Project - Budget App #1

cherelemma · 2023-09-23T04:37:17Z

Hello Dear CR ✋

I hope this message finds you well. I am submitting a pull request for your review and feedback on the implementation of the RoR Capstone project. I implemented the project requirements and ensure comprehensive test coverage. Also, I maintained the general requirements.

Project Requirements

Design

Should follow these design guidelines, including:
- Colors.
- Typography: font face, size, and weight.
- Layout: composition and space between elements.

Interactions

Splash screen
- A simple page with the name of the app, and links to the signup and login pages.
Sign up and login pages
- The user should be able to register in the app with full name, email, and password (all mandatory).
- The user can log into the app using email and password.
- If the user is not logged in, they can't access pages that require the user to be logged in (all the pages described below).
Home page (categories page)
- When the user logs in, they are presented with the categories page.
- For each category, the user can see their name, icon, and the total amount of all the transactions that belong to that category.
- When the user clicks (or taps) on a category item, the application navigates to the transactions page for that category.
- There is a button "add a new category" at the bottom that brings the user to the page to create a new category.
Transactions page
- For a given category, the list of transactions is presented, ordered by the most recent.
- At the top of the page the user could see the total amount for the category (sum of all of the amounts of the transactions in that category).
- There is a button "add a new transaction" at the bottom that brings the user to the page to create a new transaction.
- When the user clicks on the "Back" button (<), the user navigates to the home page.
"Add a new category" page
- The user fills out a form to create a new category, indicating their name and icon (both mandatory).
- The user clicks (or taps) the "Save" button to create the new category, and is taken to the home page on success.
- When the user clicks on the "Back" button (<), the user navigates to the home page.
"Add a new transaction" page
- The user fills out a form to create a new transaction with:
  - name (mandatory)
  - amount (mandatory)
  - categories (mandatory at least one)
- The user click (or taps) the "Save" button to create the new transaction, and is taken to the transactions page for that category.
- When the user clicks on the "Back" button (<), the user navigates to the transactions page for that category.

Testing requirements

Create unit and integration tests for all the most important components of your RoR application.

Technical requirements

You should use Postgres as your database.
You should use a devise for authentication.
You should validate all user input to make sure that anyone with bad intentions cannot compromise your app.
You can use a view template engine of your choice (.erb, .slim, .haml).
The project should be deployed and accessible online.
Your database schema should reflect the ERD provided

General Requirements

There are No linter errors
Follow correct GitFlow
Follow the list of best practices for Ruby.
Document my work in a professional way.

…ram/rails-budget-app-v2 into feature-branch

Munsa1

Hi @cherelemma,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation but you are almost there!

Suggested changes

Check the comments under the review.

Video Presentation Feedback 🎥

Great video presentation, it was great as your English was clear and concise. I would urge you to redo the video as you took your time and ended up rushing the video presentation at the end causing you to NOT finish the presentation well.
If you think about it, this presentation is going to be watched by potential recruiters, and as such you want to have a well-recorded presentation.
Also, you did NOT specifically HIGHLIGHT exactly what PIECE of CODE or FEATURE you found interesting to implement, this is required, so kindly do so.
Otherwise great presentation, and good composure I would only advise you to speed up your presentation a LITTLE bit so you are able to finish within the given 5 minutes without rushing it at the end

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._

You can also consider:
-N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Munsa1 · 2023-09-23T20:24:12Z

app/views/entities/new.html.erb

+<%= form_with(model: @entity, url: category_entities_path) do |form| %>
+    <div class = "app_header">
+        <a href ="<%= category_entities_path %>">
+            <i class="fa-solid fa-arrow-left" id="left-arrow"></i>
+        </a>
+        <p> New Transaction </p>
+        <a href="/logout" id = "logout" >
+            Logout
+        </a>
+    </div>
+
+    <div class = "form-container">
+        <div class="field">
+            <%= form.text_field :name, placeholder: "Name "%>
+            <% if @entity.errors.any? %>
+                <span class="alert">
+                    <%= @entity.errors[:name].first %>
+                </span>
+            <% end %>
+        </div>
+
+        <div class="field">
+            <%= form.text_field :amount, placeholder: "Price "%>
+            <% if @entity.errors.any? %>
+                <span class="alert">
+                    <%= @entity.errors[:amount].first %>
+                </span>
+            <% end %>
+        </div>
+
+        <%= form.submit "Save", class: "submit-button" %>
+    </div>
+<% end %>


As required the user should fill out a form to create a new transaction with:
name (mandatory)
amount (mandatory)
categories (mandatory at least one)

At the moment only two fields are available because the category is being added automatically, kindly fix this.

Your form

Munsa1 · 2023-09-23T20:42:34Z

app/views/entities/index.html.erb

+<div class = "app_header">
+  <a href= "<%= categories_path %>">
+    <i class="fa-solid fa-arrow-left" id = "left-arrow"></i>
+  </a>
+  <h2> Transactions</h2>
+  <a href = "/logout" id = "logout">Logout</a>
+</div>
+
+<div class="categories">
+  <% if @entities.nil? || @entities.empty?%>
+      <div class="no-record">
+        <p>No Transaction for this Category. </p>
+        <p>Please Add a Transaction</p>
+      </div>
+  <% else %>
+      <div class="total-amount">
+        <p>Total: <%= @category.total_transactions%>$</p>
+      </div>
+
+      <% @entities.each do |entity| %>
+        <div class = "transaction" >
+          <p><%= entity.name %></p>
+          <p>Price: <%= entity.amount %>$ </p>
+        </div>
+      <% end %>
+  <% end %>
+</div>
+
+<div class ="footer">
+    <i class="fa-solid fa-plus"></i>
+    <%= link_to 'New Transaction', new_category_entity_path, class: "footer_link" %>
+</div>
+


Kindly follow the given design so as to meet the requirements more. Here we need to make a small change.

Given design

Your design

Kindly change the color of the Add Category to match the given design

Kindly ensure the price for each transaction is aligned to the right as is in the given design

Note these changes apply to the categories form page, transactions page and form page as well

Munsa1 · 2023-09-23T20:44:35Z

app/views/entities/index.html.erb

+  <h2> Transactions</h2>
+  <a href = "/logout" id = "logout">Logout</a>


Kindly ensure you use the given font family for the entire app as this is a requirement. The given font is Proxima Nova Bold and not Arial which is currently being used

Munsa1 · 2023-09-23T20:48:00Z

db/migrate/20230921225144_add_devise_to_users.rb

+
+      ## Trackable
+      # t.integer  :sign_in_count, default: 0, null: false
+      # t.datetime :current_sign_in_at
+      # t.datetime :last_sign_in_at
+      # t.string   :current_sign_in_ip
+      # t.string   :last_sign_in_ip


Kindly consider removing ALL commented lines of code from this file for a cleaner codebase

cherelemma added 30 commits September 18, 2023 22:55

create a new rails app

f50aa6d

update database configuration

87f99f2

install all required gem

71221eb

add Github wirkflow and linter config files

ddd8563

install stylelint package

bf0f299

generate rspec helpers

80a9fb2

craete user model

74c8cb5

create category mode

7d0299d

create entity model

26b9ee5

run migration and create a schema

2f30541

generate devise install and configure

69378c9

generate a devise views

ee1a799

ceate a devise user model

0601ae4

update schema and setup default page

0fcd60a

create splash screen

9f5b7b9

add style and format sign and signup pages

36e3b8c

add model validations

f701028

update schema

3436f28

enable confirmable module

e1cff9e

permit name attribute for User model

21752f6

add categories and entities route

69e4a81

create Categories_controller and add actions

6f5133c

create and format Categories view

f72ebfb

create Entities_controller and add actions

4e92ea5

create Entity views

822f347

add fontawesome CDN link

9dac588

fix ruby and style linter errors

006d6e3

add @media screen for responsivenes

ba1b86d

update the font size and weight of categories and entities contenct

5ba1167

add locale error message and display inline with form elment

f4419bb

cherelemma added 5 commits September 22, 2023 22:35

install testing gem and configure rspec

04ffff2

create factoryBot for user model

f834cc7

add a user model unit test

a291f23

add unit test for category model

ce3aa8d

create unit test for Entity model

2fdaf3c

cherelemma self-assigned this Sep 23, 2023

cherelemma added the In Review label Sep 23, 2023

cherelemma added 21 commits September 23, 2023 07:42

fix linters error wirh rubocop

62acdea

add rails-controller-testing gem

b8adced

create controllers testing

edb348b

fix linter errors

8d85f2c

create HomePage feature tests

969635f

create Category feature tests

1262498

create Entity feature tests

a09c752

Update the default README

52fa328

create render github action

5a904e0

Update README.md

b6bbcc8

Update README.md

aafaef5

Update README.md

0f0e530

add lock file and fix deploy platform

4f7ecc1

Merge branch 'feature-branch' of github.com:Microverse-Fullstack-Prog…

2d49f79

…ram/rails-budget-app-v2 into feature-branch

update database production config

3a08df3

update deployment config

b9e9152

update render.yml

f6d35a1

Update production.rb

00203a8

upgrade the responders version

c9cd680

Merge branch 'feature-branch' of github.com:Microverse-Fullstack-Prog…

14c7122

…ram/rails-budget-app-v2 into feature-branch

create new credentials.yml.enc

de80ef8

Munsa1 suggested changes Sep 23, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RoR Capstone Project - Budget App #1

RoR Capstone Project - Budget App #1

cherelemma commented Sep 23, 2023

Munsa1 left a comment •

edited

Loading

Munsa1 Sep 23, 2023

Munsa1 Sep 23, 2023

Munsa1 Sep 23, 2023

Munsa1 Sep 23, 2023 •

edited

Loading

		<h2> Transactions</h2>
		<a href = "/logout" id = "logout">Logout</a>

RoR Capstone Project - Budget App #1

Are you sure you want to change the base?

RoR Capstone Project - Budget App #1

Conversation

cherelemma commented Sep 23, 2023

Hello Dear CR ✋

Project Requirements

Design

Interactions

Testing requirements

Technical requirements

General Requirements

Munsa1 left a comment • edited Loading

Choose a reason for hiding this comment

Suggested changes

Video Presentation Feedback 🎥

Munsa1 Sep 23, 2023

Choose a reason for hiding this comment

Munsa1 Sep 23, 2023

Choose a reason for hiding this comment

Note these changes apply to the categories form page, transactions page and form page as well

Munsa1 Sep 23, 2023

Choose a reason for hiding this comment

Munsa1 Sep 23, 2023 • edited Loading

Choose a reason for hiding this comment

Munsa1 left a comment •

edited

Loading

Munsa1 Sep 23, 2023 •

edited

Loading