RoR Group Capstone - Recipe App #31
Conversation
Recipe App [Milestone 1] - Set up project
…Fullstack-Program/rails-recipe-appv2 into login-and-registration-pages
…pinng-list Recipe app: Feature/shopping list
…lstack-Program/rails-recipe-appv2 into unit-and-integration-test
…lstack-Program/rails-recipe-appv2 into unit-and-integration-test
…egration-test Unit and integration test
There was a problem hiding this comment.
Hi @cherelemma @Enning94 and @Odongo006
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
📌 No Linters error ✅
📌 Descriptive pull request✅
📌 Great working on the set up of the project ✅
📌 Nice Design✅
📌 Good commit messages ✅
📌 Professional README file ✅
Required Changes ♻️
Check the comments under the review.
-
Please you have 5 of your unit tests failing so make sure that you fix them 🙏
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
app/views/recipes/_form.html.erb
Outdated
| placeholder: 'New inventory name', | ||
| class: 'form-control' | ||
| %> |
There was a problem hiding this comment.
- I suggest that the placeholder for this should be
New recipe nameinstead of 'New inventory name' since this form is for creating recipes not inventory 😊
app/views/recipes/show.html.erb
Outdated
| <% if @recipe.public %> checked <% end %>> | ||
| <label class="form-check-label" for="flexSwitchCheckReverse">Public</label> |
There was a problem hiding this comment.
- Please make sure that clicking on a recipe switch icon should switch a recipe from public to private when it is public or private to public when it is private. 🙏
app/views/recipes/_form.html.erb
Outdated
| autocomplete: 'description', | ||
| placeholder: 'Description of the inventory', |
There was a problem hiding this comment.
- I suggest that the placeholder for this should be
Description of the recipeinstead ofDescription of the inventorysince this form is for creating recipes and not inventory 😊
Recipe_App:Review changes
…ecipe-appv2 into dev
Hello Dear CR ✋
I hope this message finds you well. I am submitting a pull request for your review and feedback on the implementation of the Recipe App. I, @cherelemma, @Enning94, and @Odongo006 collaborate to implement the project requirements. We believe the implementation fulfills the project requirements and also maintains the general requirements.
Project Requirements ✔️
In this Project We:
General requirements ✔️
We have thoroughly reviewed the project requirements and cross-checked the implementation of the Blog app against the given description to ensure accuracy.
We'd like to ask for a review, as your feedback and suggestions are invaluable in ensuring the quality and efficiency of the project.
Thank you in advance for your time and assistance. We look forward to your feedback and addressing any concerns to enhance the overall quality of the project.