Resolved 2 issues with multi threaded code for issue #57 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e name if the command is executed fast enough.
If 2 threads reached if (!cache.TryGetValue(type, out mapping)) before an item was added to the cache both threads would then try to add the item to the cache causing the second to fail. By adding a lock and a second TryGetValue we can prevent this by allowing the first thread to successfully add the item to cache then release the lock. When the second thread is no longer blocked it will do a TryGetValue and retrieve the value from cache.
This was referenced Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by switching to GUID
Fixed by adding a lock around the code to add the item to the cache dictionary to prevent 2 threads trying to add the same item.