PM-1343 S3 fallback #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simisimis
approved these changes
Mar 22, 2024
Sventimir
approved these changes
Mar 26, 2024
README.md
Outdated
Comment on lines
42
to
51
| **3. AWS S3 Configuration**: | ||
|
|
||
| - `AWS_S3_BUCKET` - AWS S3 Bucket | ||
| - `NETWORK_NAME` - Network name (in case block does not exist in Cassandra | ||
| we attampt to download it from AWS S3 from `AWS_S3_BUCKET`\\`NETWORK_NAME`\blocks) | ||
| - `AWS_REGION` - The AWS region. | ||
| - `AWS_ACCESS_KEY_ID` - Your AWS Access Key ID. | ||
| - `AWS_SECRET_ACCESS_KEY` - Your AWS Secret Access Key. | ||
|
|
||
|
|
There was a problem hiding this comment.
It would be nice to mention whether these options are mandatory or not and how does the program behave in their absence (if it does not exit).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces S3 fallback functionality. In case
raw_blockis missing for particular submission in Cassandra we attempt to download it fromAWS_S3_BUCKET/NETWORK_NAME/blocks/blockhash.dat. Such updated submission list we pass todelegation-verify.