Merge pull request #14203 from MinaProtocol/feature/rm-old-version-li…

…nter Remove old version linter
MinaProtocol · Sep 27, 2023 · 26e0cb2 · 26e0cb2
2 parents 2e7ba61 + d4b5574
commit 26e0cb2
Show file tree

Hide file tree

Showing 14 changed files with 2 additions and 418 deletions.
diff --git a/buildkite/src/Jobs/Lint/Fast.dhall b/buildkite/src/Jobs/Lint/Fast.dhall
@@ -32,8 +32,6 @@ in  Pipeline.build
             S.strictly (S.contains "Makefile"),
             S.strictlyStart (S.contains "src/"),
             S.strictlyStart (S.contains "rfcs/"),
-            S.exactly "scripts/compare_ci_diff_types" "sh",
-            S.exactly "scripts/compare_ci_diff_binables" "sh",
             S.exactly "scripts/check-snarky-submodule" "sh"
           ]
         , path = "Lint"
@@ -51,31 +49,5 @@ in  Pipeline.build
               , image = (../../Constants/ContainerImages.dhall).toolchainBase
               }
             }
-        , Command.build
-            Command.Config::{
-            , commands =
-                RunInToolchain.runInToolchain
-                  [ "CI=true"
-                  , "BASE_BRANCH_NAME=\$BUILDKITE_PULL_REQUEST_BASE_BRANCH"
-                  ]
-                  "./scripts/compare_ci_diff_types.sh"
-            , label = "Versions compatibility linter"
-            , key = "lint-types"
-            , target = Size.Medium
-            , docker = None Docker.Type
-            }
-        , Command.build
-            Command.Config::{
-            , commands =
-                RunInToolchain.runInToolchain
-                  [ "CI=true"
-                  , "BASE_BRANCH_NAME=\$BUILDKITE_PULL_REQUEST_BASE_BRANCH"
-                  ]
-                  "./scripts/compare_ci_diff_binables.sh"
-            , label = "Binable compatibility linter"
-            , key = "lint-binable"
-            , target = Size.Medium
-            , docker = None Docker.Type
-            }
         ]
       }
diff --git a/scripts/compare_binables.py b/scripts/compare_binables.py
diff --git a/scripts/compare_ci_diff_binables.sh b/scripts/compare_ci_diff_binables.sh
diff --git a/scripts/compare_ci_diff_types.sh b/scripts/compare_ci_diff_types.sh
diff --git a/scripts/compare_ci_diff_types_develop.sh b/scripts/compare_ci_diff_types_develop.sh
diff --git a/scripts/compare_pr_diff_binables.py b/scripts/compare_pr_diff_binables.py
diff --git a/scripts/compare_pr_diff_items.py b/scripts/compare_pr_diff_items.py
diff --git a/scripts/compare_pr_diff_types.py b/scripts/compare_pr_diff_types.py
diff --git a/scripts/compare_versioned_items.py b/scripts/compare_versioned_items.py
diff --git a/scripts/compare_versioned_types.py b/scripts/compare_versioned_types.py
diff --git a/scripts/version-linter.py b/scripts/version-linter.py
@@ -188,6 +188,8 @@ def check_type_shapes(pr_branch_dict,base_branch,base_type_dict,release_branch,r
   base_branch=sys.argv[2]
   release_branch=sys.argv[3]
 
+  subprocess.run(['git','fetch'],capture_output=False)
+
   base_branch_commit=branch_commit(base_branch)
   download_type_shapes('base',base_branch,base_branch_commit)
 

diff --git a/src/lib/ppx_version/tools/dune b/src/lib/ppx_version/tools/dune