try to fix the staged_ledger test #14058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
deepthiskumar
approved these changes
Sep 19, 2023
| @@ -37,7 +37,22 @@ let zkapp_command_with_ledger ?num_keypairs ?max_account_updates | |||
| Option.value num_keypairs | |||
| ~default:((max_account_updates * 2) + (max_token_updates * 3) + 2) | |||
| in | |||
| let keypairs = List.init num_keypairs ~f:(fun _ -> Keypair.create ()) in | |||
| let existing_keypairs = | |||
There was a problem hiding this comment.
Since this is not used elsewhere, could you move this under the keypairs block of code?
| Array.map l ~f:(fun (kp, _balance, _nonce, _timing) -> kp) | ||
| |> Keypair.Set.of_array ) | ||
| in | ||
| let keypairs = |
There was a problem hiding this comment.
rename this to new_keypairs?
…tocol/mina into fix/staged-ledger-test-zkapp-gen
…ed-ledger-test-zkapp-gen
|
!ci-build-me |
|
!ci-build-me |
…tocol/mina into fix/staged-ledger-test-zkapp-gen
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
mrmr1993
requested changes
Sep 22, 2023
| |> Keypair.Set.of_array ) | ||
| in | ||
| List.init num_keypairs ~f:(fun _ -> | ||
| let keypair = ref (Keypair.create ()) in |
There was a problem hiding this comment.
Quickcheck generators are supposed to be deterministic, but Keypair.create will be different each time. Can you fix this so that the generator give the same output for the same input seed?
added 3 commits
September 25, 2023 23:35
…tocol/mina into fix/staged-ledger-test-zkapp-gen
…ed-ledger-test-zkapp-gen
|
!ci-build-me |
mrmr1993
approved these changes
Sep 25, 2023
|
!approved-for-mainnet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
This PR tries to fix a staged_ledger unit test bug. The generation of zkApps and user_commands sometimes could crash in their pick of keypairs. This PR fixes that.
Explain how you tested your changes:
*
Checklist: