Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zkapp generator improvements #14201

Merged
merged 7 commits into from
Oct 8, 2023
Merged

Zkapp generator improvements #14201

merged 7 commits into from
Oct 8, 2023

Conversation

georgeee
Copy link
Member

@georgeee georgeee commented Sep 25, 2023 •
edited
Loading

Explain your changes:

  • Fix some inconsistencies in zkapp generator
  • Update balance allocation and add a unit test for the generator
  • Support assigning different fee parameters to payments and zkapps

Together, this changes enabled a successful 72-hour test on the large cluster.

Explain how you tested your changes:

  • Tested on a cluster of 200 nodes, results here

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues?

@georgeee georgeee requested review from a team as code owners September 25, 2023 17:47
@georgeee
Copy link
Member Author

!ci-build-me

1 similar comment
@georgeee
Copy link
Member Author

georgeee commented Oct 4, 2023

!ci-build-me

@georgeee georgeee force-pushed the georgeee/zkapp-gen-improvements branch from 0dfc417 to 1fc96f2 Compare October 4, 2023 21:26
@georgeee
Copy link
Member Author

georgeee commented Oct 4, 2023

!ci-build-me

@georgeee georgeee force-pushed the georgeee/zkapp-gen-improvements branch from 1fc96f2 to c768234 Compare October 5, 2023 20:04
@georgeee
Copy link
Member Author

georgeee commented Oct 5, 2023

!ci-build-me

@georgeee georgeee force-pushed the georgeee/zkapp-gen-improvements branch from c768234 to 23a18ea Compare October 6, 2023 16:07
@georgeee
Copy link
Member Author

georgeee commented Oct 6, 2023

!ci-build-me

@georgeee georgeee force-pushed the georgeee/zkapp-gen-improvements branch from 23a18ea to 7ff40ed Compare October 6, 2023 17:26
@georgeee
Copy link
Member Author

georgeee commented Oct 6, 2023

!ci-build-me

@georgeee georgeee force-pushed the georgeee/zkapp-gen-improvements branch from 7ff40ed to 802a3ea Compare October 6, 2023 19:02
@georgeee
Copy link
Member Author

georgeee commented Oct 6, 2023

!ci-build-me

@georgeee
Improvements to zkapp generator
5e3581e 
1. Use memo and fee range
2. Make max_account_updates configurable
3. Change type string of zkapp in internal logging to
   `zkapp:<num acc upds>:<num proofs>`
4. Reduce checking interval in `wait_until_zkapps_deployed`
@georgeee
Change balance allocated per key
46f3fd3
@georgeee
Refactor generator
dec72b4
@georgeee
Add unit test for generator
f01cc1e
@georgeee
Use maxAccountUpdates in generator/orchestrator
319b6a2
@georgeee
Support separate payment/zkapp fee parameters in generator
4fda9f2
@georgeee
Nits
2e870c1
@georgeee georgeee force-pushed the georgeee/zkapp-gen-improvements branch from 802a3ea to 2e870c1 Compare October 7, 2023 18:57
@georgeee
Copy link
Member Author

georgeee commented Oct 7, 2023

!ci-build-me

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar deepthiskumar merged commit 9752e23 into berkeley Oct 8, 2023
2 checks passed
@deepthiskumar deepthiskumar deleted the georgeee/zkapp-gen-improvements branch October 8, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinMinkov MartinMinkov MartinMinkov approved these changes

@ghost-not-in-the-shell ghost-not-in-the-shell ghost-not-in-the-shell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@georgeee @deepthiskumar @ghost-not-in-the-shell @MartinMinkov