Limit zkApp Commands Hardcap

[ejMina226]

Limit zkApp Commands to n >=0 in case of emergency
(See #14783)

[ejMina226]

!ci-build-me

[ejMina226]

!ci-build-me

[ejMina226]

!ci-build-me

[ejMina226]

!ci-build-me

[ejMina226]

I did one simple test on this locally. I just ran a single bp node and set the limit to 0. I was told the apply_diff method is applied by a bp to itself after the block candidate is produced so when I fired a zkapp transaction at it the block height didn't change.

I will try a more sophisticated set up next.

[ejMina226]

!ci-build-me

[ejMina226]

I conducted the test as outlined in the RFC (i.e. a network with a seed bp node without this fix and a non-seed/non-bp node with this fix, and checked that the block height never increased for the latter when zkapp transactions started). The test performed as expected.

[ejMina226]

!ci-build-me

[ejMina226]

@georgeee Thanks for the review. Could you approve when you're happy?

[ejMina226]

!ci-build-me

[ejMina226]

@georgeee Do you know if there is an issue with Nix? The pipeline seems to be failing there. Thanks.

[georgeee]

!ci-build-me

[georgeee]

!ci-build-me

[ejMina226]

!ci-build-me

[georgeee]

@ejMina226 some errors appear on Ci after merge of berkeley, could you take a look?

[ejMina226]

Hi @georgeee . It's a strange error. It's saying that there's an argument missing to the following function (Zkapp_command.Valid.to_valid) However, I didn't touch this function.

[ejMina226]

Actually, I've fixed one issue.

[ejMina226]

!ci-build-me

[mrmr1993]

!approved-for-mainnet

[ejMina226]

@georgeee @mrmr1993 @deepthiskumar Can this be merged?