Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Swap to using Koin for DI, do not rely on any global context #106

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

0ffz
Copy link
Member

@0ffz 0ffz commented Oct 26, 2024

This is a fairly large refactor to allow multiple instances of geary to run at once, we call each instance a world and it can tich independently. The primary bottleneck was relying on global instances of our Geary module. This has been replaced with individual class references and an isolated Koin application when running engine setup.

  • Remove dependency on Idofront DI in favor of Koin
  • Remove any static dependency references, refer to them using a Geary object with helpers instead
  • Refactor engine modules to have no recursive dependencies
  • Rework methods for registering geary and installing addons
  • Add tests to ensure engine module is set up correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants