Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to check for explicit permission state #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

burdoto
Copy link
Contributor

@burdoto burdoto commented Mar 22, 2024

Fixes #47

@burdoto burdoto marked this pull request as ready for review March 22, 2024 15:49
@burdoto
Copy link
Contributor Author

burdoto commented Mar 24, 2024

This PR is known to fix #47 inherently; tested on Bukkit and Fabric versions.

@Yann151924
Copy link
Member

Please add a settings explicite-permission-check :

options {
   ...
   explicite-permission-check: true
}

If people want to activate this or not and put it at true by default :)

@burdoto
Copy link
Contributor Author

burdoto commented Apr 28, 2024

not sure why this should be deactivatable; it is considered good practice to require explicit permission states for meta permissions, such as autojoin.
do you have an edge case in mind that i didnt come up with?

@Yann151924
Copy link
Member

Yann151924 commented Apr 28, 2024

I don't have a specific case in mind but i think it's preferable to have a toggle of it in case someone don't want this behavior.

@burdoto
Copy link
Contributor Author

burdoto commented Apr 28, 2024

this only affects autojoin permissions; as old usages simply fall back to not requiring explicit state if not necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OP players join into the wrong channel
2 participants