Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mistralai to > 1.0.0 in preparation for latest models such as Pixtral #531

Open
wants to merge 4 commits into
base: release/v1.10
Choose a base branch
from

Conversation

skylarbpayne
Copy link

@skylarbpayne skylarbpayne commented Sep 29, 2024

Related to #521

Why?

Mistral has released a vision model, Pixtral. Supporting vision for Mistral in mirascope requires bumping up the version to the latest major version to take advantage of image capabilities.

What?

Migrates Mistral usage to v1.0.0, according to the migration guide.

The major changes are that the separate sync/async clients were merged into a single one with 4 separate functions under a chat attribute: complete, stream, complete_async, stream_async -- with some corresponding changes to the response formats.

Additionally, several enums were replaced with Literal types.

Additional Context

I have filed a bug related to support of the TypedDict versions of the message types: mistralai/client-python#149

Testing

  • All mistral tests pass
  • Examples using mistral run; on spot check they look correct. But let me know if there's better validation I can do here.

@skylarbpayne skylarbpayne marked this pull request as ready for review September 29, 2024 21:58
mirascope/core/mistral/_utils/_setup_call.py Outdated Show resolved Hide resolved
mirascope/core/mistral/_utils/_setup_call.py Outdated Show resolved Hide resolved
mirascope/core/mistral/dynamic_config.py Outdated Show resolved Hide resolved
mirascope/core/mistral/_utils/_convert_message_params.py Outdated Show resolved Hide resolved
examples/learn/calls/custom_client/mistral/shorthand.py Outdated Show resolved Hide resolved
examples/learn/calls/custom_client/mistral/shorthand.py Outdated Show resolved Hide resolved
tests/core/mistral/_utils/test_setup_call.py Outdated Show resolved Hide resolved
mirascope/core/mistral/message.py Outdated Show resolved Hide resolved
mirascope/core/mistral/message.py Outdated Show resolved Hide resolved
@skylarbpayne skylarbpayne force-pushed the bump-mistral branch 2 times, most recently from 861f53c to 37ecfd3 Compare October 7, 2024 21:23
mirascope/core/mistral/stream.py Outdated Show resolved Hide resolved
mirascope/core/mistral/stream.py Outdated Show resolved Hide resolved
mirascope/core/mistral/call_response.py Outdated Show resolved Hide resolved
mirascope/core/mistral/call_response.py Outdated Show resolved Hide resolved
mirascope/core/mistral/call_response.py Outdated Show resolved Hide resolved
mirascope/core/mistral/_utils/_convert_message_params.py Outdated Show resolved Hide resolved
mirascope/core/mistral/_utils/_convert_message_params.py Outdated Show resolved Hide resolved
mirascope/core/mistral/_utils/_convert_message_params.py Outdated Show resolved Hide resolved
mirascope/core/mistral/_utils/_convert_message_params.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 93.82716% with 5 lines in your changes missing coverage. Please review.

Project coverage is 99.95%. Comparing base (8dcb4db) to head (f464127).

Files with missing lines Patch % Lines
...ope/core/mistral/_utils/_convert_message_params.py 69.23% 4 Missing ⚠️
mirascope/core/mistral/_utils/_setup_call.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release/v1.5     #531      +/-   ##
================================================
- Coverage        100.00%   99.95%   -0.05%     
================================================
  Files               350      350              
  Lines             10471    10482      +11     
================================================
+ Hits              10471    10477       +6     
- Misses                0        5       +5     
Flag Coverage Δ
tests 99.95% <93.82%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willbakst willbakst changed the base branch from main to release/v1.5 October 11, 2024 04:41
@willbakst willbakst changed the base branch from release/v1.5 to release/v1.6 October 18, 2024 10:04
@willbakst willbakst changed the base branch from release/v1.6 to main October 24, 2024 23:00
@willbakst willbakst changed the base branch from main to release/v1.7 October 24, 2024 23:21
@willbakst willbakst changed the base branch from release/v1.7 to release/v1.8 November 1, 2024 17:45
@willbakst willbakst changed the base branch from release/v1.8 to release/v1.9 November 8, 2024 19:19
@willbakst willbakst changed the base branch from release/v1.9 to release/v1.10 November 15, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants