-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Spark 4.0 #297
Draft
dolfinus
wants to merge
1
commit into
develop
Choose a base branch
from
feature/test-spark4.0
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Test Spark 4.0 #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #297 +/- ##
===========================================
- Coverage 94.84% 94.70% -0.14%
===========================================
Files 210 210
Lines 8200 8219 +19
Branches 1413 1420 +7
===========================================
+ Hits 7777 7784 +7
- Misses 299 305 +6
- Partials 124 130 +6 ☔ View full report in Codecov by Sentry. |
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 25, 2024 18:52
0e55abd
to
b91db4e
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 25, 2024 19:02
b91db4e
to
3d1d944
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 25, 2024 19:08
3d1d944
to
469c1d9
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 25, 2024 19:20
469c1d9
to
dd21d0a
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 25, 2024 19:26
dd21d0a
to
776f351
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 25, 2024 19:32
776f351
to
0ef84bd
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 12:28
0ef84bd
to
d0c9090
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 12:47
d0c9090
to
1a00a33
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 12:52
1a00a33
to
dca6397
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 13:00
dca6397
to
d050a2d
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 13:45
d050a2d
to
849659e
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 13:53
849659e
to
978dc31
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 14:06
978dc31
to
e68423d
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
July 29, 2024 14:11
e68423d
to
ffaba47
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
August 21, 2024 09:43
ffaba47
to
9aa28e7
Compare
dolfinus
force-pushed
the
feature/test-spark4.0
branch
from
August 28, 2024 13:23
9aa28e7
to
c8969e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
get_packages()
andcheck_if_supported()
methods, as Spark 4.0 includes XML support.DecimalType(38, 10).typeName()
started returningdecimal(38, 10)
instead ofdecimal
, which breaks some Oracle tests. UpdatedSparkTypeToHWM
implementation to have direct mapping between Spark data type classes and HWM classes.TODO:
Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rst
file added describing change(see CONTRIBUTING.rst for details.)