Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.13 #298

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Test Python 3.13 #298

wants to merge 1 commit into from

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Jul 27, 2024

Change Summary

Python 3.13 does not allow inheritance like A -> B, A -> C, B+C -> D, this leads to raising error TypeError: multiple bases have instance lay-out conflict.
This was used in 2 cases - mixin classes based on Pydantic models, and inheritance schema like Options(ReadOptions, WriteOptions), ReadWriteFormat(ReadOnlyFormat, WriteOnlyFormat). Replaced with copy-paste of original classes content.

Core tests are failing because PyArrow (dependency of PySpark) does not currently provide apache/arrow#43343 apache/arrow#43519 wheels for Python 3.13.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Jul 27, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.47%. Comparing base (bd34ef3) to head (c741095).

Files with missing lines Patch % Lines
...ection/db_connection/jdbc_connection/connection.py 87.09% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #298      +/-   ##
===========================================
+ Coverage    95.44%   95.47%   +0.02%     
===========================================
  Files          225      225              
  Lines         8986     9032      +46     
  Branches       895      896       +1     
===========================================
+ Hits          8577     8623      +46     
- Misses         290      292       +2     
+ Partials       119      117       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant