Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Censors radio frequency from radio transmissions. No peeking #2163

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ProfessorPopoff
Copy link
Contributor

About The Pull Request

image

This PR removes the frequency LORE DROP from every single one of your messages. Gone are the days of the entire bar knowing FREQUENCY your radio is set to just because it popped off in public.

Why It's Good For The Game

This is a massive roleplay W. Players will no longer be able to just casually meta snag radio frequencies through text with no effort, and will be required to acquire the radio themselves if they want to peek inside. This is a big thing considering we don't do the encryption keys. (They wouldn't be needed if this was a base feature >:( )

Changelog

🆑
del: Radio freq drops on say
/:cl:

@ProfessorPopoff ProfessorPopoff marked this pull request as draft September 15, 2022 07:05
@ProfessorPopoff ProfessorPopoff marked this pull request as ready for review September 15, 2022 07:05
@ProfessorPopoff
Copy link
Contributor Author

Post PR clarity: We should probably have the text differentiate between radios and something like intercoms. That way it's easier to tell what's going on at any moment.

@TheRealScarHomie
Copy link
Contributor

(RADIO)

@AndrewL97
Copy link
Collaborator

@ProfessorPopoff
What if we put the name of the radio it came from? I.e Handset, Ham Radio, etc.

@ProfessorPopoff
Copy link
Contributor Author

ProfessorPopoff commented Sep 17, 2022

@ProfessorPopoff What if we put the name of the radio it came from? I.e Handset, Ham Radio, etc.

I would really love to. I just don't exactly know how to go about it.

@ProfessorPopoff ProfessorPopoff marked this pull request as draft October 3, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants