Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The peeper - Looking into the distance #2253

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ProfessorPopoff
Copy link
Contributor

@ProfessorPopoff ProfessorPopoff commented Jan 17, 2023

About The Pull Request

Adds in an alt-rmb action that zooms your vision into the rough direction you're looking. Currently only supports Norf/Eaftst/Souf/Wefst. Can be done at any time.

Things to do:

  • Make it disable FOV cones or something so it doesn't look dumb
  • Maybe lock your character's direction to the way you're looking
  • Fix random runtime I can't figure out. HELP....
  • Give it a formal patdown and think about what else we want to integrate into it :)

Why It's Good For The Game

People should be able to user their peepers to peep.

Desktop_2023.01.12_-_05.00.02.35.DVR.mp4
wielding.1.mp4

@ProfessorPopoff ProfessorPopoff changed the title The peeper The peeper - Looking into the distance Jan 17, 2023
@blackcrystall
Copy link

blackcrystall commented Jan 25, 2023

first step - change update_fov() proc

Proc supposed look like that:

/mob/living/proc/update_fov()
	var/highest_fov
	if(CONFIG_GET(flag/native_fov))
		highest_fov = native_fov
	for(var/trait_type in fov_traits)
		var/fov_type = fov_traits[trait_type]
		if(fov_type == "no_fov")
			highest_fov = 0
			break
		if(fov_type > highest_fov)
			highest_fov = fov_type
	fov_view = highest_fov
	update_fov_client()

add_fov_trait
remove_fov_trait
use that procs, with "no_fov" as second var, you can def "no_fov" as value, if like using something like #definite DISABLE_FOV_BLOCKER 361
but if you want something cool, like fov changing and reposition ask me, i already think about this is mechanic, i can help you to make that

@ProfessorPopoff
Copy link
Contributor Author

This is mostly all good, though I'm going to keep it as a draft until we can get some sort of follower PR. With a bit of thought, it's come to realization that people would use this to attack mobs from a distance, and until we're sure that there's a way to work around that, this shouldn't be added.

@github-actions github-actions bot added the Merge Conflict Merge conflict label May 17, 2023
@Mannybrado
Copy link
Contributor

alt rmb? zomg lifeweb reference

@github-actions github-actions bot removed the Merge Conflict Merge conflict label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants