-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final round of changes and latest audit #89
Open
dekanbro
wants to merge
133
commits into
Moloch-Mystics:feat/baalZodiac
Choose a base branch
from
HausDAO:feat/baalZodiac
base: feat/baalZodiac
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Final round of changes and latest audit #89
dekanbro
wants to merge
133
commits into
Moloch-Mystics:feat/baalZodiac
from
HausDAO:feat/baalZodiac
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: dekanbro <[email protected]>
* adding referral data * adjusting internal methods
* adding upgradeable to Baal Votes * adding upgradeable to loot token * adding changes from slither * removing overrides on erc20s __name, __symbol for oz permits erc20 _name, _symbol * removing template? * upgradin package; adding tests to deploy npm * updating version
* wi[ on upgradable tokens * init ownership and test that baal can renounce or transfer it * some tests * start on eject test * start on eject test * add some updated tests, wip, eject test not working * update eoa test to work * remove unneeded test Co-authored-by: dekanbro <[email protected]>
Add openGSN support to Baal
Revert "Add openGSN support to Baal"
* move pausable function to token, todo: test failes on minting when paused * clean up console logs * remove pausable modifier for custom logic * update loot token tests * add comments * fix syntax typo * remove name and symbol from destructing * address review, fix if else logic, remove pause vailibles because they are in the token now Co-authored-by: dekanbro <[email protected]>
* move pausable function to token, todo: test failes on minting when paused * clean up console logs * remove pausable modifier for custom logic * update loot token tests * add comments * fix syntax typo * remove name and symbol from destructing * address review, fix if else logic, remove pause vailibles because they are in the token now * Add OpenGSN support to Baal (#73) * Add OpenGSN support to Baal * Add tests * Add docstrings * Drop hardhat configs for large contracts * Use init params to pass in forwarder * Clean up tests Co-authored-by: dekanbro <[email protected]> Co-authored-by: Akshaan Kakar <[email protected]>
* make tribute minion payable and forward to baal new proposal * add tests * allow self-sponsor proposal if called through TributeMinion * add more test coverage for sponsor/tribute scenarios Co-authored-by: dekanbro <[email protected]> Co-authored-by: Santiago Gonzalez <[email protected]>
…eable dependencies on oz
Co-authored-by: dekanbro <[email protected]>
Audit fixes brian
updated deployment for optimism
Fixture updates
update publish workflow node version
Enable Sepolia and Base chains
Fix imports
move safe-deployments to package dependencies
fix typings & update docs
Factory upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.