Skip to content

Commit

Permalink
Merge pull request #277 from KittyNoodle/quirkfix
Browse files Browse the repository at this point in the history
  • Loading branch information
Zonespace27 authored Aug 25, 2023
2 parents 9e90a6b + a0b2e9f commit d57fe5d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
9 changes: 3 additions & 6 deletions code/datums/quirks/negative_quirks.dm
Original file line number Diff line number Diff line change
Expand Up @@ -634,12 +634,9 @@
added_trama_ref = WEAKREF(added_trauma)

/datum/quirk/insanity/post_add()
if(!quirk_holder.mind || quirk_holder.mind.special_role)
return
// I don't /think/ we'll need this, but for newbies who think "roleplay as insane" = "license to kill",
// it's probably a good thing to have.
to_chat(quirk_holder, span_big(span_bold(span_info("Please note that your [lowertext(name)] does NOT give you the right to attack people or otherwise cause any interference to \
the round. You are not an antagonist, and the rules will treat you the same as other crewmembers."))))
var/rds_policy = get_policy("[type]") || "Please note that your [lowertext(name)] does NOT give you any additional right to attack people or cause chaos."
// I don't /think/ we'll need this, but for newbies who think "roleplay as insane" = "license to kill", it's probably a good thing to have.
to_chat(quirk_holder, span_big(span_info(rds_policy)))

/datum/quirk/insanity/remove()
QDEL_NULL(added_trama_ref)
Expand Down
5 changes: 4 additions & 1 deletion code/game/say.dm
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ GLOBAL_LIST_INIT(freqtospan, list(
continue
hearing_movable.Hear(null, src, message_language, message, null, spans, message_mods, range)

/atom/movable/proc/compose_message(atom/movable/speaker, datum/language/message_language, raw_message, radio_freq, list/spans, list/message_mods = list(), face_name = FALSE)
/atom/movable/proc/compose_message(atom/movable/speaker, datum/language/message_language, raw_message, radio_freq, list/spans, list/message_mods = list(), face_name = FALSE, visible_name = FALSE)
//This proc uses text() because it is faster than appending strings. Thanks BYOND.
//Basic span
var/spanpart1 = "<span class='[radio_freq ? get_radio_span(radio_freq) : "game say"]'>"
Expand All @@ -94,6 +94,9 @@ GLOBAL_LIST_INIT(freqtospan, list(
if(face_name && ishuman(speaker))
var/mob/living/carbon/human/H = speaker
namepart = "[H.get_face_name()]" //So "fake" speaking like in hallucinations does not give the speaker away if disguised
else if(visible_name && ishuman(speaker))
var/mob/living/carbon/human/human_speaker = speaker
namepart = "[human_speaker.get_visible_name()]"
//End name span.
var/endspanpart = "</span>"

Expand Down
2 changes: 1 addition & 1 deletion code/modules/mob/living/living_say.dm
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ GLOBAL_LIST_INIT(message_modes_stat_limits, list(
SEND_SIGNAL(src, COMSIG_MOVABLE_HEAR, args)

if(HAS_TRAIT(speaker, TRAIT_SIGN_LANG)) //Checks if speaker is using sign language
deaf_message = compose_message(speaker, message_language, raw_message, radio_freq, spans, message_mods)
deaf_message = compose_message(speaker, message_language, raw_message, radio_freq, spans, message_mods, FALSE, TRUE)

if(speaker != src)
if(!radio_freq) //I'm about 90% sure there's a way to make this less cluttered
Expand Down

0 comments on commit d57fe5d

Please sign in to comment.